openstack/cinder
Code Issues Proposed changes

Use VolumeDriverException for driver exceptions

Browse Source 
These exceptions are volume-driver specific and should
be inherited from VolumeDriverException rather than
CinderException.

Change-Id: I1ceeb15144f06340734084b544b903b6b93e8b07
This commit is contained in:
Eric Harney 2016-11-01 13:12:03 -04:00
parent 11218eba7b
commit 1ce4063a12
1 changed files with 16 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
cinder/exception.py
View File

@ -1086,7 +1086,7 @@ class InvalidGroupSnapshot(Invalid):
# Hitachi Block Storage Driver
class HBSDError(CinderException):
class HBSDError(VolumeDriverException):
message = _("HBSD error occurs.")
@ -1197,53 +1197,53 @@ class ZadaraVolumeNotFound(VolumeDriverException):
# ZFSSA NFS driver exception.
class WebDAVClientError(CinderException):
class WebDAVClientError(VolumeDriverException):
message = _("The WebDAV request failed. Reason: %(msg)s, "
"Return code/reason: %(code)s, Source Volume: %(src)s, "
"Destination Volume: %(dst)s, Method: %(method)s.")
# XtremIO Drivers
class XtremIOAlreadyMappedError(CinderException):
class XtremIOAlreadyMappedError(VolumeDriverException):
message = _("Volume to Initiator Group mapping already exists")
class XtremIOArrayBusy(CinderException):
class XtremIOArrayBusy(VolumeDriverException):
message = _("System is busy, retry operation.")
class XtremIOSnapshotsLimitExceeded(CinderException):
class XtremIOSnapshotsLimitExceeded(VolumeDriverException):
message = _("Exceeded the limit of snapshots per volume")
# Infortrend EonStor DS Driver
class InfortrendCliException(CinderException):
class InfortrendCliException(VolumeDriverException):
message = _("Infortrend CLI exception: %(err)s Param: %(param)s "
"(Return Code: %(rc)s) (Output: %(out)s)")
# DOTHILL drivers
class DotHillInvalidBackend(CinderException):
class DotHillInvalidBackend(VolumeDriverException):
message = _("Backend doesn't exist (%(backend)s)")
class DotHillConnectionError(CinderException):
class DotHillConnectionError(VolumeDriverException):
message = _("%(message)s")
class DotHillAuthenticationError(CinderException):
class DotHillAuthenticationError(VolumeDriverException):
message = _("%(message)s")
class DotHillNotEnoughSpace(CinderException):
class DotHillNotEnoughSpace(VolumeDriverException):
message = _("Not enough space on backend (%(backend)s)")
class DotHillRequestError(CinderException):
class DotHillRequestError(VolumeDriverException):
message = _("%(message)s")
class DotHillNotTargetPortal(CinderException):
class DotHillNotTargetPortal(VolumeDriverException):
message = _("No active iSCSI portals with supplied iSCSI IPs")
@ -1270,7 +1270,7 @@ class NotSupportedOperation(Invalid):
# Hitachi HNAS drivers
class HNASConnError(CinderException):
class HNASConnError(VolumeDriverException):
message = _("%(message)s")
@ -1312,13 +1312,13 @@ class KaminarioRetryableException(VolumeDriverException):
# Synology driver
class SynoAPIHTTPError(CinderException):
class SynoAPIHTTPError(VolumeDriverException):
message = _("HTTP exit code: [%(code)s]")
class SynoAuthError(CinderException):
class SynoAuthError(VolumeDriverException):
message = _("Synology driver authentication failed: %(reason)s.")
class SynoLUNNotExist(CinderException):
class SynoLUNNotExist(VolumeDriverException):
message = _("LUN not found by UUID: %(uuid)s.")