openstack
/
cinder
Code Issues Proposed changes

Use cinders test class in cloudbyte unit tests 

The cloudbyte unit tests were inheritting directly from
testtols so they weren't getting all the goodness from
the default fixutre setup, most noticeably the logging
setup.  The result was a bunch of noise generated in
the unit test output.

This changes the base class for the cloudbyte unit tests
to pull in cinder.tests instead of testtools directly,
which fixes up the noise.

There are a still a number of places where cloudbyte is
accessing testtools directly, which may or may not be ok.

Change-Id: Ic4cfdc99ba17f0999a382db96020aa583b876020
Closes-Bug: #1593808
This commit is contained in:
John Griffith 2016-06-17 12:05:50 -06:00
parent a26117f6ae
commit 207f5cf5e9
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
cinder/tests/unit/test_cloudbyte.py
View File

@ -27,6 +27,7 @@ from testtools import matchers
from cinder import context
from cinder import exception
from cinder import test
from cinder.volume import configuration as conf
from cinder.volume.drivers.cloudbyte import cloudbyte
from cinder.volume import qos_specs
@ -648,7 +649,7 @@ MAP_COMMAND_TO_FAKE_RESPONSE['listiSCSIAuthGroup'] = (
json.loads(FAKE_LIST_ISCSI_AUTH_GROUP_RESPONSE))
class CloudByteISCSIDriverTestCase(testtools.TestCase):
class CloudByteISCSIDriverTestCase(test.TestCase):
def setUp(self):
super(CloudByteISCSIDriverTestCase, self).setUp()