openstack/cinder
Code Issues Proposed changes

Update URL for global HACKING document and remove duplicate section

Browse Source 
* Related to I579e7c889f3addc2cd40bce0c584bbc70bf435e2

* Remove section on locals since its already in global hacking doc
  (http://git.openstack.org/cgit/openstack-dev/hacking/tree/doc/source/index.rst#n154)

Change-Id: I5acb06dfde6eb7f579d8d52bc31fafbdab8c726d
This commit is contained in:
Joe Gordon 2013-11-11 11:28:18 -08:00
parent 54b117d26e
commit 20d177db37
1 changed files with 1 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
HACKING.rst
View File

@ -2,7 +2,7 @@ Cinder Style Commandments
========================= =========================
- Step 1: Read the OpenStack Style Commandments - Step 1: Read the OpenStack Style Commandments
https://github.com/openstack-dev/hacking/blob/master/doc/source/index.rst http://docs.openstack.org/developer/hacking/
- Step 2: Read on - Step 2: Read on
Cinder Specific Commandments Cinder Specific Commandments
@ -10,15 +10,6 @@ Cinder Specific Commandments
General General
------- -------
- Do not use locals(). Example::
LOG.debug(_("volume %(vol_name)s: creating size %(vol_size)sG") %
locals()) # BAD
LOG.debug(_("volume %(vol_name)s: creating size %(vol_size)sG") %
{'vol_name': vol_name,
'vol_size': vol_size}) # OKAY
- Use 'raise' instead of 'raise e' to preserve original traceback or exception being reraised:: - Use 'raise' instead of 'raise e' to preserve original traceback or exception being reraised::
except Exception as e: except Exception as e: