openstack
/
cinder
Code Issues Proposed changes

Fix config option volume_backend_name's invalid overridden value 

oslo.config made method set_override with enforce_type=True
by default[1], will try to convert override value according to config
option's type. Config option volume_backend_name is StrOpt[2], need
be overridden with string value.

Closes-Bug: #1681334

[1] https://review.openstack.org/#/c/328692/
[2] http://git.openstack.org/cgit/openstack/cinder/tree/cinder/volume/driver.py#n66

Change-Id: If246b5fd91c7fc2c381acc56ef499ada7f411741
This commit is contained in:
ChangBo Guo(gcb) 2017-04-10 16:01:28 +08:00
parent 1205ec79cd
commit 2c938e9d9e
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
cinder/tests/unit/windows/test_windows.py
View File

@ -404,11 +404,11 @@ class TestWindowsDriver(test.TestCase):
mock.sentinel.size_gb,
mock.sentinel.free_space_gb)
self.flags(volume_backend_name=mock.sentinel.backend_name)
self.flags(volume_backend_name='volume_backend_name')
self.flags(reserved_percentage=10)
expected_volume_stats = dict(
volume_backend_name=mock.sentinel.backend_name,
volume_backend_name='volume_backend_name',
vendor_name='Microsoft',
driver_version=self._driver.VERSION,
storage_protocol='iSCSI',