openstack
/
cinder
Code Issues Proposed changes

Add comment to online data migration command 

One of the requirements of the online data migration command is that
they must be able to be run without any Cinder service running in order
to support a normal upgrade or a Fast-Forward upgrade.

With the introduction of the shared_targets feature we added an online
migration that requires the Cinder services to be running (it does RPC
calls).

To prevent this from happening again this patch adds a comment right
above the online_migrations tupple as a reminder for reviewers.

Change-Id: I911ddee5a62edc95bedbfd644804abd8b206e957
This commit is contained in:
Gorka Eguileor 2018-09-11 22:17:49 +02:00
parent 7eb4e1d0a8
commit 2cd5957c5e
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
cinder/cmd/manage.py
View File

@ -259,6 +259,9 @@ class HostCommands(object):
class DbCommands(object):
"""Class for managing the database."""
# NOTE: Online migrations cannot depend on having Cinder services running.
# Migrations can be called during Fast-Forward Upgrades without having any
# Cinder services up.
online_migrations = (
# Added in Queens
db.service_uuids_online_data_migration,