From 2da9df9405c0459d543f3119b1bda45e3ac59d8c Mon Sep 17 00:00:00 2001 From: Rajat Dhasmana Date: Mon, 23 Jun 2025 14:06:44 +0000 Subject: [PATCH] Pin flake8-import-order<0.19.0 flake8-import-order has a new release[1] on June 20th that breaks Cinder in a different way. ./cinder/api/api_utils.py:28:1: I300 TYPE_CHECKING block should have one newline above. ./cinder/api/common.py:32:1: I300 TYPE_CHECKING block should have one newline above. ./cinder/cmd/backup.py:48:1: I300 TYPE_CHECKING block should have one newline above. ./cinder/cmd/volume.py:52:1: I300 TYPE_CHECKING block should have one newline above. It would be good to fix the changes but for now, it's best to pin the flake8-import-order to <0.19.X where the jobs were stable. We can pin it to a higher version when needed but we want to unblock the gate as a priority for now. [1] https://pypi.org/project/flake8-import-order/0.19.1/ Change-Id: Ic99814a61c93a9249ae9fbe5ecd5c510cb6e31ed (cherry picked from commit 4b96a9a88e350b6c1192f192b07c9af1f0f31747) Conflicts: test-requirements.txt --- test-requirements.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test-requirements.txt b/test-requirements.txt index 0b0e20c6d60..70e647ed5eb 100644 --- a/test-requirements.txt +++ b/test-requirements.txt @@ -4,7 +4,7 @@ # Install bounded pep8/pyflakes first, then let flake8 install hacking>=7.0.0,<7.1.0 # Apache-2.0 -flake8-import-order # LGPLv3 +flake8-import-order<0.19.0 # LGPLv3 flake8-logging-format>=0.6.0 # Apache-2.0 stestr>=3.2.1 # Apache-2.0