openstack
/
cinder
Code Issues Proposed changes

Use $state_path/conversion for image_conversion_dir default 

image_conversion_dir currently defaults to /tmp.  Using
$state_path/conversion seems to be a more appropriate default.

Closes-Bug: #1217552
Change-Id: Iaaa462449a257b1b48fc349399bf409d7301a1e6
This commit is contained in:
Eric Harney 2013-09-13 09:43:33 -04:00
parent cd3c5cf9b0
commit 37e775f125
2 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
cinder/image/image_utils.py
View File

@ -22,7 +22,7 @@ Helper methods to deal with images.
This is essentially a copy from nova.virt.images.py
Some slight modifications, but at some point
we should look at maybe pushign this up to OSLO
we should look at maybe pushing this up to Oslo
"""
@ -44,8 +44,9 @@ from cinder.volume import utils as volume_utils
LOG = logging.getLogger(__name__)
image_helper_opt = [cfg.StrOpt('image_conversion_dir',
default='/tmp',
help='parent dir for tempdir used for image conversion'), ]
default='$state_path/conversion',
help='Directory used for temporary storage '
'during image conversion'), ]
CONF = cfg.CONF
CONF.register_opts(image_helper_opt)

6
etc/cinder/cinder.conf.sample
View File

@ -537,9 +537,9 @@
# Options defined in cinder.image.image_utils
#
# parent dir for tempdir used for image conversion (string
# value)
#image_conversion_dir=/tmp
# Directory used for temporary storage during image conversion
# (string value)
#image_conversion_dir=$state_path/conversion
#