openstack/cinder
Code Issues Proposed changes

Port EMC VMAX to Python 3

Browse Source 
* Fix EMCVMAXMasking._get_storage_group_from_masking_view_instance():
  replace "if groups[0] > 0:" with "if len(groups):"
* tests-py3.txt: add cinder.tests.unit.test_emc_vmax

Partial-Implements: blueprint cinder-python3
Change-Id: I0f6be3cc0873efe683d39c4c70e19d0d0b79beb8
This commit is contained in:
Victor Stinner
2015-11-09 12:54:16 +01:00
parent b12fb487b4
commit 3a5cf11156
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cinder/volume/drivers/emc/emc_vmax_masking.py
View File

@@ -1096,7 +1096,7 @@ class EMCVMAXMasking(object):
groups = conn.AssociatorNames(
maskingViewInstance,
ResultClass='CIM_DeviceMaskingGroup')
if groups[0] > 0:
if len(groups) > 0:
foundStorageGroupInstanceName = groups[0]
return foundStorageGroupInstanceName

1
tests-py3.txt
View File

@@ -56,6 +56,7 @@ cinder.tests.unit.test_dellsc
cinder.tests.unit.test_dellscapi
cinder.tests.unit.test_dothill
cinder.tests.unit.test_drbdmanagedrv
cinder.tests.unit.test_emc_vmax
cinder.tests.unit.test_emc_vnxdirect
cinder.tests.unit.test_emc_xtremio
cinder.tests.unit.test_eqlx