openstack/cinder
Code Issues Proposed changes

mypy: Cover cinder/flow_utils.py

Browse Source 
Fix implicit optional annotations currently
throwing errors in this file.

Change-Id: I828e0851f7d62917331d5485a820df79785afb4b
This commit is contained in:
Eric Harney 2023-03-21 09:59:10 -04:00
parent ac31b9e2b3
commit 3c6c2ee656
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
cinder/flow_utils.py
View File

@ -13,7 +13,7 @@
from __future__ import annotations from __future__ import annotations
import os import os
from typing import Any from typing import Any, Optional # noqa: H301
from oslo_log import log as logging from oslo_log import log as logging
# For more information please visit: https://wiki.openstack.org/wiki/TaskFlow # For more information please visit: https://wiki.openstack.org/wiki/TaskFlow
@ -27,7 +27,7 @@ from cinder import exception
LOG = logging.getLogger(__name__) LOG = logging.getLogger(__name__)
def _make_task_name(cls, addons: list[str] = None) -> str: def _make_task_name(cls, addons: Optional[list[str]] = None) -> str:
"""Makes a pretty name for a task class.""" """Makes a pretty name for a task class."""
base_name = ".".join([cls.__module__, cls.__name__]) base_name = ".".join([cls.__module__, cls.__name__])
extra = '' extra = ''
@ -43,11 +43,13 @@ class CinderTask(task.Task):
implement the given task as the task name. implement the given task as the task name.
""" """
def __init__(self, addons: list[str] = None, **kwargs: Any) -> None: def __init__(self,
addons: Optional[list[str]] = None,
**kwargs: Any) -> None:
super(CinderTask, self).__init__(self.make_name(addons), **kwargs) super(CinderTask, self).__init__(self.make_name(addons), **kwargs)
@classmethod @classmethod
def make_name(cls, addons: list[str] = None) -> str: def make_name(cls, addons: Optional[list[str]] = None) -> str:
return _make_task_name(cls, addons) return _make_task_name(cls, addons)

1
mypy-files.txt
View File

@ -19,6 +19,7 @@ cinder/image/glance.py
cinder/image/image_utils.py cinder/image/image_utils.py
cinder/keymgr/transfer.py cinder/keymgr/transfer.py
cinder/exception.py cinder/exception.py
cinder/flow_utils.py
cinder/manager.py cinder/manager.py
cinder/objects/backup.py cinder/objects/backup.py
cinder/policy.py cinder/policy.py