openstack
/
cinder
Code Issues Proposed changes

Change default glance_num_retries to 3 

Previously, the default value of glance_num_retries is 0. It means
that the request to glance is issued only one time. However, other
components' client retries the request when it fails.
To reduce an unnecessary exception and failure, we should increase
the default value to 3.

Change-Id: Iff8162c732fb9dc0080e8810b4a5bcaa3ff7e6ca
(cherry picked from commit da5a27f7b3)
This commit is contained in:
Keigo Noha 2020-07-08 15:54:49 +09:00
parent 53d4822751
commit 45f2e24cc7
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cinder/common/config.py
View File

@ -174,7 +174,7 @@ image_opts = [
'is not specified it defaults to http.'),
cfg.IntOpt('glance_num_retries',
min=0,
default=0,
default=3,
help='Number retries when downloading an image from glance'),
cfg.BoolOpt('glance_api_insecure',
default=False,

9
releasenotes/notes/increase_glance_num_retries-66b455a0729c4535.yaml Normal file
View File

@ -0,0 +1,9 @@
---
upgrade:
- |
The default value of the configuration option, ``glance_num_retries``,
has been changed to 3 in this release. Its former value was 0.
The option controls how many times to retry a Glance API call
in response to a HTTP connection failure, timeout or ServiceUnavailable status.
By this change, Cinder can be more resilient to temporary failure and continue
the request if a retry succeeds.