openstack/cinder
Code Issues Proposed changes

Merge "Added documentation about backup_file_size about memory usage"

Browse Source
This commit is contained in:
Zuul 2022-05-02 07:21:35 +00:00 committed by Gerrit Code Review
commit 5204c6eb16
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
cinder/backup/drivers/posix.py
View File

@ -42,6 +42,9 @@ posixbackup_service_opts = [
help='The maximum size in bytes of the files used to hold ' help='The maximum size in bytes of the files used to hold '
'backups. If the volume being backed up exceeds this ' 'backups. If the volume being backed up exceeds this '
'size, then it will be backed up into multiple files. ' 'size, then it will be backed up into multiple files. '
'backup_file_size also determines the buffer size '
'used to build backup files, so should be scaled '
'according to available RAM and number of workers. '
'backup_file_size must be a multiple of ' 'backup_file_size must be a multiple of '
'backup_sha_block_size_bytes.'), 'backup_sha_block_size_bytes.'),
cfg.IntOpt('backup_sha_block_size_bytes', cfg.IntOpt('backup_sha_block_size_bytes',

4
doc/source/admin/volume-backups.rst
View File

@ -141,7 +141,9 @@ deduplication or compression on the backup data.
The option ``backup_file_size`` must be a multiple of The option ``backup_file_size`` must be a multiple of
``backup_sha_block_size_bytes``. It is effectively the maximum file size to be ``backup_sha_block_size_bytes``. It is effectively the maximum file size to be
used, given your environment, to hold backup data. Volumes larger than this used, given your environment, to hold backup data. Volumes larger than this
will be stored in multiple files in the backup repository. The will be stored in multiple files in the backup repository. ``backup_file_size``
also determines the buffer size used to produce backup files; on smaller hosts
it may need to be scaled down to avoid OOM issues. The
``backup_sha_block_size_bytes`` option determines the size of blocks from the ``backup_sha_block_size_bytes`` option determines the size of blocks from the
cinder volume being backed up on which digital signatures are calculated in cinder volume being backed up on which digital signatures are calculated in
order to enable incremental backup capability. order to enable incremental backup capability.