Merge "Remove "cinder-manage shell" commands"

This commit is contained in:
Zuul 2020-09-04 17:18:49 +00:00 committed by Gerrit Code Review
commit 5602e74373
3 changed files with 5 additions and 97 deletions

View File

@ -128,79 +128,6 @@ def args(*args, **kwargs):
return _decorator return _decorator
class ShellCommands(object):
def bpython(self):
"""Runs a bpython shell.
Falls back to Ipython/python shell if unavailable
"""
self.run('bpython')
def ipython(self):
"""Runs an Ipython shell.
Falls back to Python shell if unavailable
"""
self.run('ipython')
def python(self):
"""Runs a python shell.
Falls back to Python shell if unavailable
"""
self.run('python')
@args('--shell',
metavar='<bpython|ipython|python>',
help='Python shell')
def run(self, shell=None):
"""Runs a Python interactive interpreter."""
if not shell:
shell = 'bpython'
if shell == 'bpython':
try:
import bpython
bpython.embed()
except ImportError:
shell = 'ipython'
if shell == 'ipython':
try:
from IPython import embed
embed()
except ImportError:
try:
# Ipython < 0.11
# Explicitly pass an empty list as arguments, because
# otherwise IPython would use sys.argv from this script.
import IPython
shell = IPython.Shell.IPShell(argv=[])
shell.mainloop()
except ImportError:
# no IPython module
shell = 'python'
if shell == 'python':
import code
try:
# Try activating rlcompleter, because it's handy.
import readline
except ImportError:
pass
else:
# We don't have to wrap the following import in a 'try',
# because we already know 'readline' was imported successfully.
import rlcompleter # noqa
readline.parse_and_bind("tab:complete")
code.interact()
@args('--path', required=True, help='Script path')
def script(self, path):
"""Runs the script from the specified path with flags set properly."""
exec(compile(open(path).read(), path, 'exec'), locals(), globals())
def _db_error(caught_exception): def _db_error(caught_exception):
print('%s' % caught_exception) print('%s' % caught_exception)
print(_("The above error may show that the database has not " print(_("The above error may show that the database has not "
@ -740,7 +667,6 @@ CATEGORIES = {
'db': DbCommands, 'db': DbCommands,
'host': HostCommands, 'host': HostCommands,
'service': ServiceCommands, 'service': ServiceCommands,
'shell': ShellCommands,
'version': VersionCommands, 'version': VersionCommands,
'volume': VolumeCommands, 'volume': VolumeCommands,
} }

View File

@ -111,29 +111,6 @@ Displays cinder errors from log files.
Displays cinder the most recent entries from syslog. The optional number Displays cinder the most recent entries from syslog. The optional number
argument specifies the number of entries to display (default 10). argument specifies the number of entries to display (default 10).
Cinder Shell
~~~~~~~~~~~~
``cinder-manage shell bpython``
Starts a new bpython shell.
``cinder-manage shell ipython``
Starts a new ipython shell.
``cinder-manage shell python``
Starts a new python shell.
``cinder-manage shell run``
Starts a new shell using python.
``cinder-manage shell script <path/scriptname>``
Runs the named script from the specified path with flags set.
Cinder Volume Cinder Volume
~~~~~~~~~~~~~ ~~~~~~~~~~~~~

View File

@ -0,0 +1,5 @@
---
upgrade:
- |
The "cinder-manage shell" set of commands has been removed.