openstack/cinder
Code Issues Proposed changes

Give more time for LVM deactivation

Browse Source 
Current code retries three times for deactivation to complete,
waiting one second between retries. On some heavily loaded
systems, and apparently the gate, this is not enough time for
the operation to complete.

This attempts to work around those slower systems by increasing
our retries to 5 and adding a backoff of 2 seconds to give it
more time.

Change-Id: I4f40a1984fe828c8ff965033f7e25b1d7516ab1e
Closes-bug: #1687044
This commit is contained in:
Sean McGinnis 2017-04-28 14:14:16 -05:00
parent a822e2614b
commit 5744301777
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
cinder/brick/local_dev/lvm.py
View File

@ -639,8 +639,8 @@ class LVM(executor.Executor):
# order to prevent a race condition.
self._wait_for_volume_deactivation(name)
@utils.retry(exceptions=exception.VolumeNotDeactivated, retries=3,
backoff_rate=1)
@utils.retry(exceptions=exception.VolumeNotDeactivated, retries=5,
backoff_rate=2)
def _wait_for_volume_deactivation(self, name):
LOG.debug("Checking to see if volume %s has been deactivated.",
name)