openstack/cinder
Code Issues Proposed changes

Misuse of i18n log translation to output error message

Browse Source 
I found a misuse of i18n log translation for error message
in "cinder/volume/drivers/lvm.py'.

The "%s' can not be translated. In this case, the "message'
must be i18ning and then the "message" should be output
using LOG.error().

Change-Id: I4495522d337764dc28186225f4594a227ac3e555
Signed-off-by: Mitsuhiro Tanino <mitsuhiro.tanino@hds.com>
Closes-Bug: 1334334
This commit is contained in:
Mitsuhiro Tanino 2014-06-24 19:40:36 -04:00
parent d69aa545aa
commit 663eadfb2b
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
cinder/volume/drivers/lvm.py
View File

@ -573,9 +573,9 @@ class LVMISCSIDriver(LVMVolumeDriver, driver.ISCSIDriver):
try:
(vg for vg in vg_list if vg['name'] == dest_vg).next()
except StopIteration:
message = ("Destination Volume Group %s does not exist" %
message = (_("Destination Volume Group %s does not exist") %
dest_vg)
LOG.error(_('%s'), message)
LOG.error(message)
return false_ret
helper = utils.get_root_helper()