From 8759488e076da4b8f9fac9f10e34f226a73cf67c Mon Sep 17 00:00:00 2001 From: Simon Dodsley Date: Tue, 8 Apr 2025 10:19:20 -0400 Subject: [PATCH] [Pure Storage] Fix issue with NVMe LACP ports not being identified When using NVMe as a dataplane, target ports are identified directly from the backend. When an LACP bond is created this was not being correctly identified as valid. This patch resolves this issue. This patch is standalone for 2024.1 as the codebase changed for 2024.2 and this bug is addressed in a seperate patch for that release. Closes-Bug: #2101859 Change-Id: Ic511d040fec57fb681f09c4f7459b222e16b84f7 (cherry picked from commit d4c63178975939f7df99a33a66c6704565d06e4c) --- cinder/volume/drivers/pure.py | 2 +- .../notes/pure_storage_nvme_lacp-ef1a2a911c7ecc75.yaml | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) create mode 100644 releasenotes/notes/pure_storage_nvme_lacp-ef1a2a911c7ecc75.yaml diff --git a/cinder/volume/drivers/pure.py b/cinder/volume/drivers/pure.py index 2b3f1e64d94..3be29cc2457 100644 --- a/cinder/volume/drivers/pure.py +++ b/cinder/volume/drivers/pure.py @@ -3446,7 +3446,7 @@ class PureNVMEDriver(PureBaseVolumeDriver, driver.BaseVD): valid_nvme_ports = [] nvme_ports = [port for port in ports if port["nqn"]] for port in range(0, len(nvme_ports)): - if "ETH" in nvme_ports[port]["name"]: + if "FC" not in nvme_ports[port]["name"]: port_detail = array.get_network_interface( interface=nvme_ports[port]["name"] ) diff --git a/releasenotes/notes/pure_storage_nvme_lacp-ef1a2a911c7ecc75.yaml b/releasenotes/notes/pure_storage_nvme_lacp-ef1a2a911c7ecc75.yaml new file mode 100644 index 00000000000..957127f9381 --- /dev/null +++ b/releasenotes/notes/pure_storage_nvme_lacp-ef1a2a911c7ecc75.yaml @@ -0,0 +1,6 @@ +--- +fixes: + - | + Pure Storage `bug #2101859 + `_: Fixed issue where + LACP bonds were not been correctly identified as NVMe targets.