From 0df29396bfa4eca306b5e4700defbfa5d5637b24 Mon Sep 17 00:00:00 2001 From: haailani Date: Fri, 3 Jun 2022 11:15:23 +0000 Subject: [PATCH] [SVf] : Fix the SVC code level for lsfcportsetmember call [Spectrum Virtualize family] lsfcportsetmember call was introduced in SVC code level 8.5.x. But during portset implementation, lsfcportsetmember was included in 8.4.2.0 which is incorrect as SVC 8.4.2.0 doesn't recognise this command. Correcting the SVC code level for lsfcportsetmember call. Closes-Bug: #1976499 Change-Id: Ia9f22d630ff9d9541bb36e5506679dd15c27d5d5 --- .../volume/drivers/ibm/storwize_svc/storwize_svc_common.py | 2 +- ...alled_in_the_wrong_SVC_code_level-db06c4eca902f389.yaml | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) create mode 100644 releasenotes/notes/bug-1976499-storwize-lsfcportsetmember_is_being_called_in_the_wrong_SVC_code_level-db06c4eca902f389.yaml diff --git a/cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py b/cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py index e4153521308..b1e6fb6d1ec 100644 --- a/cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py +++ b/cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py @@ -1160,7 +1160,7 @@ class StorwizeHelpers(object): # indicates whether the port can be used for host I/O targetportfc_resp = self.ssh.lstargetportfc(current_node_id=node_id, host_io_permitted=host_io) - if code_level >= (8, 4, 2, 0): + if code_level >= (8, 5, 0, 0): portset_name = portset if portset else 'portset64' port_ids = set() fcportsetmember_resp = self.ssh.lsfcportsetmember() diff --git a/releasenotes/notes/bug-1976499-storwize-lsfcportsetmember_is_being_called_in_the_wrong_SVC_code_level-db06c4eca902f389.yaml b/releasenotes/notes/bug-1976499-storwize-lsfcportsetmember_is_being_called_in_the_wrong_SVC_code_level-db06c4eca902f389.yaml new file mode 100644 index 00000000000..5b0d8bed279 --- /dev/null +++ b/releasenotes/notes/bug-1976499-storwize-lsfcportsetmember_is_being_called_in_the_wrong_SVC_code_level-db06c4eca902f389.yaml @@ -0,0 +1,7 @@ +--- +fixes: + - | + IBM Spectrum Virtualize Family driver: `Bug #1976499 + `_: + Setting correct SVC Code level for lsfcportsetmember + call.