openstack
/
cinder
Code Issues Proposed changes

Retype functionality in Tintri driver 

At this point default retype behavior is as follows. If a volume changes
type on the same backend then that volume will be migrated. Since Tintri
VMstore does not differentiate between volume types, we can avoid this
migration by implementing retype functionality.

Change-Id: I40b28327e13821d6fb45f89b15267b21ed4c2e8c
closes-bug: 1524435
This commit is contained in:
apoorvad 2015-12-09 09:42:21 -08:00
parent c3aa40dc9b
commit 918d33eee9
2 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
cinder/tests/unit/test_tintri.py
View File

@ -245,3 +245,9 @@ class TintriDriverTestCase(test.TestCase):
volume = fake_volume.fake_volume_obj(self.context)
volume.provider_location = self._provider_location
self._driver.unmanage(volume)
def test_retype(self):
volume = fake_volume.fake_volume_obj(self.context)
retype, update = self._driver.retype(None, volume, None, None, None)
self.assertTrue(retype)
self.assertIsNone(update)

8
cinder/volume/drivers/tintri.py
View File

@ -704,6 +704,14 @@ class TintriDriver(driver.ManageableVD,
raise exception.ManageExistingInvalidReference(
existing_ref=vol_ref, reason=_('Volume not found.'))
def retype(self, context, volume, new_type, diff, host):
"""Retype from one volume type to another.
At this point Tintri VMstore does not differentiate between
volume types on the same array. This is a no-op for us.
"""
return True, None
class TClient(object):
"""REST client for Tintri storage."""