openstack/cinder
Code Issues Proposed changes

Clean up QoSSpecManageApiTest setup

Browse Source 
There is currently unnecessary work being performed in setUp
for QoSSpecManageApiTest and confusing comments. This cleans
that up to avoid confusion.

Test was explicitly calling a reset on a fake, but the cleanup
for each test will do this as well. Relatively harmless, but
this makes the code cleaner.

Change-Id: I2671fc0a186acb75767d9adb1edeb9ad705fc958
This commit is contained in:
Sean McGinnis 2015-01-09 09:42:48 -06:00
parent 9742b7d361
commit 96b1d5b8a2
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
cinder/tests/api/contrib/test_qos_specs_manage.py
View File

@ -145,10 +145,7 @@ class QoSSpecManageApiTest(test.TestCase):
self.flags(host='fake')
self.controller = qos_specs_manage.QoSSpecsController()
#reset notifier drivers left over from other api/contrib tests
# NOTE(flaper87) WTF? ^^^^ Cleanups should happen in each test,
# not the purpose of this patch, though.
fake_notifier.reset()
# Reset notifications for each test
self.addCleanup(fake_notifier.reset)
def test_index(self):