From 96b1d5b8a2abf92df6aab201807ad11e021fcf2b Mon Sep 17 00:00:00 2001 From: Sean McGinnis Date: Fri, 9 Jan 2015 09:42:48 -0600 Subject: [PATCH] Clean up QoSSpecManageApiTest setup There is currently unnecessary work being performed in setUp for QoSSpecManageApiTest and confusing comments. This cleans that up to avoid confusion. Test was explicitly calling a reset on a fake, but the cleanup for each test will do this as well. Relatively harmless, but this makes the code cleaner. Change-Id: I2671fc0a186acb75767d9adb1edeb9ad705fc958 --- cinder/tests/api/contrib/test_qos_specs_manage.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/cinder/tests/api/contrib/test_qos_specs_manage.py b/cinder/tests/api/contrib/test_qos_specs_manage.py index f7fe5e68b8c..23db1da2eb1 100644 --- a/cinder/tests/api/contrib/test_qos_specs_manage.py +++ b/cinder/tests/api/contrib/test_qos_specs_manage.py @@ -145,10 +145,7 @@ class QoSSpecManageApiTest(test.TestCase): self.flags(host='fake') self.controller = qos_specs_manage.QoSSpecsController() - #reset notifier drivers left over from other api/contrib tests - # NOTE(flaper87) WTF? ^^^^ Cleanups should happen in each test, - # not the purpose of this patch, though. - fake_notifier.reset() + # Reset notifications for each test self.addCleanup(fake_notifier.reset) def test_index(self):