openstack/cinder
Code Issues Proposed changes

PowerMax Driver - QoS calculation failure

Browse Source 
The value for 'host_io_limit_mb_sec' is not correctly being cast to
an int and U4P REST will only accept an whole int between 1 and
100000.

Change-Id: Idb3841f39428de93f0482cf7785fcf398487e595
(cherry picked from commit 99916612d3)
This commit is contained in:
Helen Walsh
2019-10-11 17:05:13 +01:00
parent ef025a7935
commit 99327feccd
4 changed files with 30 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
cinder/tests/unit/volume/drivers/dell_emc/powermax/test_powermax_utils.py
View File

@@ -531,6 +531,30 @@ class PowerMaxUtilsTest(test.TestCase):
sg_value, qos_extra_spec, input_prop_dict)
self.assertEqual(input_prop_dict, ret_prop_dict)
def test_validate_qos_cast_to_int(self):
qos_extra_spec = {'total_iops_sec': '500',
'total_bytes_sec': '104857600',
'DistributionType': 'Always'}
property_dict = {'host_io_limit_io_sec': 500}
input_prop_dict = {'host_io_limit_io_sec': 500,
'host_io_limit_mb_sec': 100}
input_key = 'total_bytes_sec'
ret_prop_dict = self.utils.validate_qos_input(
input_key, None, qos_extra_spec, property_dict)
self.assertEqual(input_prop_dict, ret_prop_dict)
def test_validate_qos_cast_to_int_drop_fraction(self):
qos_extra_spec = {'total_iops_sec': '500',
'total_bytes_sec': '105000000',
'DistributionType': 'Always'}
property_dict = {'host_io_limit_io_sec': 500}
input_prop_dict = {'host_io_limit_io_sec': 500,
'host_io_limit_mb_sec': 100}
input_key = 'total_bytes_sec'
ret_prop_dict = self.utils.validate_qos_input(
input_key, None, qos_extra_spec, property_dict)
self.assertEqual(input_prop_dict, ret_prop_dict)
def test_compare_cylinders(self):
source_cylinders = '12345'
target_cylinders = '12345'