openstack/cinder
Code Issues Proposed changes

set vg_thin_pool_size to float type

Browse Source 
lvsize is type of str, we need a float type.

Closes-Bug: #1715041
Change-Id: Ic9720c649ccb1fbcf2f319c0cc422c54f0925aac
This commit is contained in:
wanghongxu 2017-09-05 11:23:48 +08:00
parent 543bba9577
commit 9a386cee12
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cinder/brick/local_dev/lvm.py
View File

@ -459,7 +459,7 @@ class LVM(executor.Executor):
if not lv['size'][-1].isdigit():
lvsize = lvsize[:-1]
if lv['name'] == self.vg_thin_pool:
self.vg_thin_pool_size = lvsize
self.vg_thin_pool_size = float(lvsize)
tpfs = self._get_thin_pool_free_space(self.vg_name,
self.vg_thin_pool)
self.vg_thin_pool_free_space = tpfs

4
cinder/tests/unit/brick/test_brick_lvm.py
View File

@ -322,7 +322,7 @@ class BrickLvmTestCase(test.TestCase):
self.assertEqual(
"9.5g",
self.vg.create_thin_pool(name=self.vg.vg_thin_pool))
self.assertEqual("9.50", self.vg.vg_thin_pool_size)
self.assertEqual(9.50, self.vg.vg_thin_pool_size)
self.assertEqual(7.6, self.vg.vg_thin_pool_free_space)
self.assertEqual(3.0, self.vg.vg_provisioned_capacity)
@ -331,7 +331,7 @@ class BrickLvmTestCase(test.TestCase):
self.assertEqual(
"9.5g",
self.vg.create_thin_pool(name=self.vg.vg_thin_pool))
self.assertEqual("9.50", self.vg.vg_thin_pool_size)
self.assertEqual(9.50, self.vg.vg_thin_pool_size)
self.assertEqual(7.6, self.vg.vg_thin_pool_free_space)
self.assertEqual(3.0, self.vg.vg_provisioned_capacity)