openstack/cinder
Code Issues Proposed changes

Remove periodic_tasks method from base manager

Browse Source 
periodic_tasks method was added with 'Initial fork of Nova' commit and
refactored while moving to oslo.service. Now it doesn't do anything
except calling method from parent class.

Change-Id: I24eee484dbf047dded88297ae173689923b3f374
This commit is contained in:
Ivan Kolodyazhny 2017-07-05 19:16:36 +03:00
parent 640b870f9c
commit 9ac027e29c
2 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
cinder/manager.py
View File

@ -98,10 +98,6 @@ class Manager(base.Base, PeriodicTasks):
def service_topic_queue(self): def service_topic_queue(self):
return self.cluster or self.host return self.cluster or self.host
def periodic_tasks(self, context, raise_on_error=False):
"""Tasks to be run at a periodic interval."""
return self.run_periodic_tasks(context, raise_on_error=raise_on_error)
def init_host(self, service_id=None, added_to_cluster=None): def init_host(self, service_id=None, added_to_cluster=None):
"""Handle initialization if this is a standalone service. """Handle initialization if this is a standalone service.

2
cinder/service.py
View File

@ -471,7 +471,7 @@ class Service(service.Service):
def periodic_tasks(self, raise_on_error=False): def periodic_tasks(self, raise_on_error=False):
"""Tasks to be run at a periodic interval.""" """Tasks to be run at a periodic interval."""
ctxt = context.get_admin_context() ctxt = context.get_admin_context()
self.manager.periodic_tasks(ctxt, raise_on_error=raise_on_error) self.manager.run_periodic_tasks(ctxt, raise_on_error=raise_on_error)
def report_state(self): def report_state(self):
"""Update the state of this service in the datastore.""" """Update the state of this service in the datastore."""