openstack
/
cinder
Code Issues Proposed changes

Add missing context to function call 

Code doesn't pass the context object to a superclass call
where it is needed in a conditional branch.

Closes-bug: #1875953
Change-Id: I4467b6ed7dda01f8bd73428a0d4ee6257b0b3eb7
This commit is contained in:
Brian Rosmaita 2020-04-29 15:14:45 -04:00
parent 562fa42376
commit a49913222e
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
cinder/tests/unit/volume/drivers/test_vzstorage.py
View File

@ -419,8 +419,9 @@ class VZStorageTestCase(test.TestCase):
mock_remotefs_create_cloned_volume.return_value = {
'provider_location': self._FAKE_SHARE}
ret = drv.create_cloned_volume(volume, src_vref)
# Bug #1875953: code should also be passing context here
mock_remotefs_create_cloned_volume.assert_called_once_with(
volume, src_vref)
volume, src_vref, self.context)
self.assertEqual(ret, {'provider_location': self._FAKE_SHARE})
@mock.patch.object(vzstorage.VZStorageDriver, '_local_path_volume_info')

4
cinder/volume/drivers/vzstorage.py
View File

@ -740,5 +740,5 @@ class VZStorageDriver(remotefs_drv.RemoteFSSnapDriver):
if volume_format == DISK_FORMAT_PLOOP:
return self._create_cloned_volume_ploop(volume, src_vref)
else:
return super(VZStorageDriver, self)._create_cloned_volume(volume,
src_vref)
return super(VZStorageDriver, self)._create_cloned_volume(
volume, src_vref, context)