From a82bae3f7b56fb84377fa6571b9f21ca6809da0e Mon Sep 17 00:00:00 2001 From: Vipin Balachandran Date: Fri, 18 Jul 2014 16:08:02 +0530 Subject: [PATCH] VMware: Update default task_poll_interval value The task_poll_interval option is used as the polling interval of vCenter/ESX task status. This patch updates the default value to 0.5s in order to reduce the wait time for task completion. Similar change has been done in nova and this change is needed to keep the driver config values consistent. DocImpact Updated default value of task_poll_interval to 0.5 seconds. Change-Id: I66b80c629e255d61047592455ca42632f93051b2 Closes-bug: #1278028 --- cinder/volume/drivers/vmware/vmdk.py | 8 ++++---- etc/cinder/cinder.conf.sample | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/cinder/volume/drivers/vmware/vmdk.py b/cinder/volume/drivers/vmware/vmdk.py index 14b039fb96d..0a90d6f2445 100644 --- a/cinder/volume/drivers/vmware/vmdk.py +++ b/cinder/volume/drivers/vmware/vmdk.py @@ -70,10 +70,10 @@ vmdk_opts = [ default=10, help='Number of times VMware ESX/VC server API must be ' 'retried upon connection related issues.'), - cfg.IntOpt('vmware_task_poll_interval', - default=5, - help='The interval (in seconds) for polling remote tasks ' - 'invoked on VMware ESX/VC server.'), + cfg.FloatOpt('vmware_task_poll_interval', + default=0.5, + help='The interval (in seconds) for polling remote tasks ' + 'invoked on VMware ESX/VC server.'), cfg.StrOpt('vmware_volume_folder', default='cinder-volumes', help='Name for the folder in the VC datacenter that will ' diff --git a/etc/cinder/cinder.conf.sample b/etc/cinder/cinder.conf.sample index beb1f178763..3f8b4284c0f 100644 --- a/etc/cinder/cinder.conf.sample +++ b/etc/cinder/cinder.conf.sample @@ -1808,8 +1808,8 @@ #vmware_api_retry_count=10 # The interval (in seconds) for polling remote tasks invoked -# on VMware ESX/VC server. (integer value) -#vmware_task_poll_interval=5 +# on VMware ESX/VC server. (floating point value) +#vmware_task_poll_interval=0.5 # Name for the folder in the VC datacenter that will contain # cinder volumes. (string value)