openstack/cinder
Code Issues Proposed changes

Merge "Hacking: Ignore tools/ for C303"

Browse Source
This commit is contained in:
Jenkins
2016-04-20 17:10:16 +00:00
committed by Gerrit Code Review
parent 53d2a27da9 437f5be7c8
commit ab8d63b796
1 changed files with 13 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
cinder/hacking/checks.py
View File

@@ -415,15 +415,19 @@ def check_unicode_usage(logical_line, noqa):
def check_no_print_statements(logical_line, filename, noqa): def check_no_print_statements(logical_line, filename, noqa):
# The files in cinder/cmd do need to use 'print()' so # CLI and utils programs do need to use 'print()' so
# we don't need to check those files. Other exemptions # we shouldn't check those files.
# should use '# noqa' to avoid failing here. if noqa:
if "cinder/cmd" not in filename and not noqa: return
if re.match(no_print_statements, logical_line):
msg = ("C303: print() should not be used. " if "cinder/cmd" in filename or "tools/" in filename:
"Please use LOG.[info|error|warning|exception|debug]. " return
"If print() must be used, use '# noqa' to skip this check.")
yield(0, msg) if re.match(no_print_statements, logical_line):
msg = ("C303: print() should not be used. "
"Please use LOG.[info|error|warning|exception|debug]. "
"If print() must be used, use '# noqa' to skip this check.")
yield(0, msg)
def check_no_log_audit(logical_line): def check_no_log_audit(logical_line):