openstack/cinder
Code Issues Proposed changes

Raise VolumeNotFound with correct volume_id

Browse Source 
Make sure VolumeNotFound is raised with the correct volume_id
in the SolidFire driver. Some exceptions were wrongfully referring
to an undefined variable named uuid.

Fixes: bug #1182966
Change-Id: Ied101fc9778f51dfb74b39f466c2c13d6e775a40
This commit is contained in:
Mathieu Gagné
2013-05-22 12:25:40 -04:00
parent 96f91b8a23
commit b3db10f0ee
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
cinder/volume/drivers/solidfire.py
View File

@@ -280,7 +280,7 @@ class SolidFire(SanISCSIDriver):
if not found_volume:
LOG.error(_('Failed to retrieve volume SolidFire-'
'ID: %s in get_by_account!') % sf_volume_id)
raise exception.VolumeNotFound(volume_id=uuid)
raise exception.VolumeNotFound(volume_id=sf_volume_id)
model_update = {}
# NOTE(john-griffith): SF volumes are always at lun 0
@@ -309,7 +309,7 @@ class SolidFire(SanISCSIDriver):
sf_vol = self._get_sf_volume(src_uuid, params)
if sf_vol is None:
raise exception.VolumeNotFound(volume_id=uuid)
raise exception.VolumeNotFound(volume_id=src_uuid)
if 'qos' in sf_vol:
qos = sf_vol['qos']