openstack
/
cinder
Code Issues Proposed changes

vmware: Use cookiejar from oslo.vmware client directly 

With changing the SOAP library backing oslo.vmware [1], the cookiejar of
a session must be accessed differently. Therefore, oslo.vmware
introduced a property on the client to abstract this change away. This
commit uses the new place to access the attribute.

[1] https://specs.openstack.org/openstack/oslo-specs/specs/victoria/oslo-vmware-soap-library-switch.html

Change-Id: I8e3167debf9e378fe87c95974df2df94cf21bbd7
This commit is contained in:
Hemna 2021-02-10 16:31:30 -05:00
parent ffca1ac9f9
commit bc0fdbc7e9
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cinder/tests/unit/volume/drivers/vmware/test_vmware_vmdk.py
View File

@ -2685,7 +2685,7 @@ class VMwareVcVmdkDriverTestCase(test.TestCase):
ds_name, upload_file_path)
vops.get_entity_name.assert_called_once_with(dc_ref)
cookies = session.vim.client.options.transport.cookiejar
cookies = session.vim.client.cookiejar
if use_temp_image:
mock_open.assert_called_once_with('/tmp/foo', 'rb')
download_file.assert_called_once_with(

2
cinder/volume/drivers/vmware/vmdk.py
View File

@ -990,7 +990,7 @@ class VMwareVcVmdkDriver(driver.VolumeDriver):
port = self.configuration.vmware_host_port
ca_file = self.configuration.vmware_ca_file
insecure = self.configuration.vmware_insecure
cookies = self.session.vim.client.options.transport.cookiejar
cookies = self.session.vim.client.cookiejar
dc_name = self.volumeops.get_entity_name(dc_ref)
LOG.debug("Copying image: %(image_id)s to %(path)s.",