openstack
/
cinder
Code Issues Proposed changes

Correct VolumeMigrationStatusField 

It's not currently being used anywhere and is probably only defined
for symmetry, but it might as well be correct in case someone decides
to use it.

Change-Id: I6feb6b49df84f3f565d089ae55dee471fc1cf3e1
This commit is contained in:
Brian Rosmaita 2022-04-28 17:35:01 -04:00
parent 983f62ed50
commit be3a8279fb
2 changed files with 30 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cinder/objects/fields.py
View File

@ -213,7 +213,7 @@ class VolumeMigrationStatus(BaseCinderEnum):
class VolumeMigrationStatusField(BaseEnumField):
AUTO_TYPE = VolumeStatus()
AUTO_TYPE = VolumeMigrationStatus()
class DictOfNullableField(fields.AutoTypedField):

29
cinder/tests/unit/objects/test_fields.py
View File

@ -156,3 +156,32 @@ class TestVolumeAttachStatus(TestField):
def test_stringify_invalid(self):
self.assertRaises(ValueError, self.field.stringify, 'not_a_status')
class TestVolumeMigrationStatus(TestField):
def setUp(self):
super(TestVolumeMigrationStatus, self).setUp()
self.field = fields.VolumeMigrationStatusField()
self.coerce_good_values = [
('migrating',
fields.VolumeMigrationStatus.MIGRATING),
('error',
fields.VolumeMigrationStatus.ERROR),
('success',
fields.VolumeMigrationStatus.SUCCESS),
('completing',
fields.VolumeMigrationStatus.COMPLETING),
('starting',
fields.VolumeMigrationStatus.STARTING),
('none',
fields.VolumeMigrationStatus.NONE),
]
self.coerce_bad_values = ['available']
self.to_primitive_values = self.coerce_good_values
self.from_primitive_values = self.coerce_good_values
def test_stringify(self):
self.assertEqual("'migrating'", self.field.stringify('migrating'))
def test_stringify_invalid(self):
self.assertRaises(ValueError, self.field.stringify, 'not_a_status')