diff --git a/cinder/volume/targets/cxt.py b/cinder/volume/targets/cxt.py index 9a4b4c4cfe0..c08974f21fd 100644 --- a/cinder/volume/targets/cxt.py +++ b/cinder/volume/targets/cxt.py @@ -130,9 +130,8 @@ class CxtAdm(iscsi.ISCSITarget): if os.path.exists(volume_path): LOG.warning(_LW('Persistence file already exists for volume, ' 'found file at: %s'), volume_path) - f = open(volume_path, 'w+') - f.write(volume_conf) - f.close() + with open(volume_path, 'w+') as f: + f.write(volume_conf) LOG.debug('Created volume path %(vp)s,\n' 'content: %(vc)s', {'vp': volume_path, 'vc': volume_conf}) diff --git a/cinder/volume/targets/tgt.py b/cinder/volume/targets/tgt.py index ad93713b01e..57c02efd6ad 100644 --- a/cinder/volume/targets/tgt.py +++ b/cinder/volume/targets/tgt.py @@ -165,9 +165,8 @@ class TgtAdm(iscsi.ISCSITarget): if os.path.exists(volume_path): LOG.warning(_LW('Persistence file already exists for volume, ' 'found file at: %s'), volume_path) - f = open(volume_path, 'w+') - f.write(volume_conf) - f.close() + with open(volume_path, 'w+') as f: + f.write(volume_conf) LOG.debug(('Created volume path %(vp)s,\n' 'content: %(vc)s'), {'vp': volume_path, 'vc': volume_conf})