openstack/cinder
Code Issues Proposed changes

Add hacking check for print() statements

Browse Source 
We are frequently having to -1 patches because people
forget print() statements that were used for debug in
their development.  Can save everyone time and trouble by
adding this simple hacking check.

The check excluded the cinder/cmd directory as the files in there
legitimately need to use the print() command.  Also wsgi.py and
the test_hds_nas_backend.py files make use of print, so I have
excluded those from checking as well.

Change-Id: I2066eeb2bdc6c9af294d0b9befb7e0b32abd1378
This commit is contained in:
Jay S. Bryant
2015-04-06 11:22:09 -05:00
parent f8b6feb5eb
commit c2658d9c09
5 changed files with 42 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
HACKING.rst
View File

@@ -20,6 +20,7 @@ Cinder Specific Commandments
- [N339] Prevent use of deprecated contextlib.nested.
- [C301] timeutils.utcnow() from oslo_utils should be used instead of datetime.now().
- [C302] six.text_type should be used instead of unicode
- [C303] Ensure that there are no 'print()' statements in code that is being committed.
General