[SPDK] Add https protocol option to communicate with SPDK

Currently only http is available to communicate with SPDK
backend. This patch adds option to switch to https.

Signed-off-by: Maciej Szwed <maciej.szwed@intel.com>
Change-Id: Ice54adf6bb9456a53d10f6c5f0a1e2d0c8e58149

cinder/tests/unit/targets/test_spdknvmf.py

@@ -14,6 +14,8 @@ import copy
 import json
 from unittest import mock
 
+import requests
+
 from cinder.tests.unit import test
 from cinder.volume import configuration as conf
 from cinder.volume.targets import spdknvmf as spdknvmf_driver
@@ -355,10 +357,39 @@ class SpdkNvmfDriverTestCase(test.TestCase):
         self.configuration.target_protocol = "nvmet_rdma"
         self.configuration.spdk_rpc_ip = "127.0.0.1"
         self.configuration.spdk_rpc_port = 8000
+        self.configuration.spdk_rpc_protocol = "https"
+        self.configuration.spdk_rpc_username = "user"
+        self.configuration.spdk_rpc_password = "password"
+        self.configuration.driver_ssl_cert_verify = False
         self.driver = spdknvmf_driver.SpdkNvmf(configuration=
                                                self.configuration)
         self.jsonrpcclient = JSONRPCClient()
 
+    def get_item(self):
+        return {'result': 'test_result'}
+
+    def test__rpc_parameters(self):
+        url = ('%(protocol)s://%(ip)s:%(port)s/' %
+               {'protocol': self.configuration.spdk_rpc_protocol,
+                'ip': self.configuration.spdk_rpc_ip,
+                'port': self.configuration.spdk_rpc_port})
+        auth = (self.configuration.spdk_rpc_username,
+                self.configuration.spdk_rpc_password)
+        verify = self.configuration.driver_ssl_cert_verify
+
+        requests.post = mock.MagicMock()
+        setattr(requests.post.service.__getitem__,
+                'side_effect',
+                self.get_item)
+
+        self.driver._rpc_call("bdev_get_bdevs")
+
+        requests.post.assert_called_once_with(url,
+                                              auth=auth,
+                                              data=mock.ANY,
+                                              timeout=mock.ANY,
+                                              verify=verify)
+
     def test__get_spdk_volume_name(self):
         with mock.patch.object(self.driver, "_rpc_call",
                                self.jsonrpcclient.call):

cinder/tests/unit/volume/drivers/test_spdk.py

@@ -510,6 +510,7 @@ class SpdkDriverTestCase(test.TestCase):
         self.configuration.target_protocol = "nvmet_rdma"
         self.configuration.spdk_rpc_ip = "127.0.0.1"
         self.configuration.spdk_rpc_port = 8000
+        self.configuration.spdk_rpc_protocol = "https"
         mock_safe_get = mock.Mock()
         mock_safe_get.return_value = 'spdk-nvmeof'
         self.configuration.safe_get = mock_safe_get