openstack/cinder
Code Issues Proposed changes

Change 'host' option from HostAddressOpt to StrOpt

Browse Source 
HostAddressOpt is overly restrictive for this field --
it should actually just be a StrOpt.

Co-Author: Gorka Eguileor <geguileo@redhat.com>
Closes-Bug: #1941068
Change-Id: I7699433b283ba9aa1bd11da4f6ff4de071f1b51d
This commit is contained in:
Eric Harney 2021-08-25 11:09:05 -04:00
parent a2f0f57a06
commit c995438ca2
2 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
cinder/common/config.py
View File

@ -84,12 +84,12 @@ global_opts = [
cfg.StrOpt('scheduler_manager',
default='cinder.scheduler.manager.SchedulerManager',
help='Full class name for the Manager for scheduler'),
cfg.HostAddressOpt('host',
sample_default='localhost',
default=socket.gethostname(),
help='Name of this node. This can be an opaque '
'identifier. It is not necessarily a host name, '
'FQDN, or IP address.'),
cfg.StrOpt('host',
sample_default='localhost',
default=socket.gethostname(),
help='Name of this node. This can be an opaque '
'identifier. It is not necessarily a host name, '
'FQDN, or IP address.'),
# NOTE(vish): default to nova for compatibility with nova installs
cfg.StrOpt('storage_availability_zone',
default='nova',

7
releasenotes/notes/incorrect-host-config-option-347e60f957458d54_new.yaml Normal file
View File

@ -0,0 +1,7 @@
---
fixes:
- |
`Bug #1941068 <https://bugs.launchpad.net/cinder/+bug/1941068>`_: Fixed
type of the ``host`` configuration option. It was limited to valid FQDN
values when we document that it isn't. This may result in the
``cinder-manage db sync`` command failing.