From 075a5254c807a1acb9eaf922eead80ef3e798727 Mon Sep 17 00:00:00 2001 From: Sean McGinnis Date: Wed, 14 Jul 2021 15:02:58 -0500 Subject: [PATCH] Mark QNAP driver as unsupported The last update to the QNAP driver other than overall repo maintenance changes was over 3 years ago [0]. The CI has not reported success for over two years: Checking name: QNAP ES CI - https://wiki.openstack.org/wiki/ThirdPartySystems/QNAP_ES_CI first seen: 2017-06-13 07:19:08 (1492 days, 9:54:47 old) https://review.openstack.org/472224 last seen: 2019-04-09 07:30:20 (827 days, 9:43:35 old) https://review.openstack.org/651117 last success: 2019-03-27 21:38:37 (839 days, 19:35:18 old) https://review.openstack.org/648174 Job qnap-cinder-driver-iscsi 0% success out of 67 comments S=0, F=67 Job qnap-cinder-driver 58% success out of 170 comments S=100, F=70 last success: 2019-03-27 21:38:37 (839 days, 19:35:18 old) https://review.openstack.org/648174 There has also been some indication from users that it does not work [1]. This marks the driver as unsupported so users need to explicitly enable it if they are willing to try to make it run. [0] https://opendev.org/openstack/cinder/commit/fa9881a891290ef92d50131bc90d6215b751a2aa [1] http://lists.openstack.org/pipermail/openstack-discuss/2021-July/023640.html Signed-off-by: Sean McGinnis Change-Id: Ifdec10092feea9729ab2807296b98070317fba00 --- cinder/volume/drivers/qnap.py | 3 +++ doc/source/reference/support-matrix.ini | 2 +- .../notes/mark-unsupported-gnap-739f90232c60ab3e.yaml | 11 +++++++++++ 3 files changed, 15 insertions(+), 1 deletion(-) create mode 100644 releasenotes/notes/mark-unsupported-gnap-739f90232c60ab3e.yaml diff --git a/cinder/volume/drivers/qnap.py b/cinder/volume/drivers/qnap.py index 096ca5793f6..d963d037527 100644 --- a/cinder/volume/drivers/qnap.py +++ b/cinder/volume/drivers/qnap.py @@ -88,6 +88,9 @@ class QnapISCSIDriver(san.SanISCSIDriver): # ThirdPartySystems wiki page CI_WIKI_NAME = "QNAP_CI" + # Remove if third party CI requirements are met + SUPPORTED = False + VERSION = '1.2.005' TIME_INTERVAL = 3 diff --git a/doc/source/reference/support-matrix.ini b/doc/source/reference/support-matrix.ini index d761fb63ee6..8195b18516c 100644 --- a/doc/source/reference/support-matrix.ini +++ b/doc/source/reference/support-matrix.ini @@ -265,7 +265,7 @@ driver.nimble=complete driver.opene_joviandss=complete driver.prophetstor=missing driver.pure=complete -driver.qnap=complete +driver.qnap=missing driver.quobyte=complete driver.rbd=complete driver.rbd_iscsi=complete diff --git a/releasenotes/notes/mark-unsupported-gnap-739f90232c60ab3e.yaml b/releasenotes/notes/mark-unsupported-gnap-739f90232c60ab3e.yaml new file mode 100644 index 00000000000..372c1479416 --- /dev/null +++ b/releasenotes/notes/mark-unsupported-gnap-739f90232c60ab3e.yaml @@ -0,0 +1,11 @@ +--- +upgrade: + - | + The QNAP driver has been marked as unsupported and is now + deprecated. ``enable_unsupported_drivers`` will need to be set to + ``True`` in cinder.conf to continue to use it. +deprecations: + - | + The QNAP driver has been marked as unsupported and is now + deprecated. ``enable_unsupported_drivers`` will need to be set to + ``True`` in cinder.conf to continue to use it. \ No newline at end of file