openstack/cinder
Code Issues Proposed changes

Fix overwrite of params in SF image cache update

Browse Source 
In the update cache volume routine of the SolidFire driver
we're unintentionally re-initializing the params variable
when assigning volID as opposed to just appending another key
to it.

This patch fixes that.

Change-Id: I213776ee6aef6e5dee2807c19b7eea05af23d6c0
Closes-Bug: #1454425
This commit is contained in:
John Griffith
2015-05-12 15:48:03 -06:00
parent 79df1d730c
commit cf4c885c20
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cinder/volume/drivers/solidfire.py
View File

@@ -608,7 +608,7 @@ class SolidFireDriver(san.SanISCSIDriver):
else: else:
# Bummer, it's been updated, delete it # Bummer, it's been updated, delete it
params = {'accountID': sfaccount['accountID']} params = {'accountID': sfaccount['accountID']}
params = {'volumeID': sf_vol['volumeID']} params['volumeID'] = sf_vol['volumeID']
data = self._issue_api_request('DeleteVolume', params) data = self._issue_api_request('DeleteVolume', params)
if 'result' not in data: if 'result' not in data:
msg = _("Failed to delete SolidFire Image-Volume: %s") % data msg = _("Failed to delete SolidFire Image-Volume: %s") % data