openstack/cinder
Code Issues Proposed changes

Fix mandatory and optional args for create_volume

Browse Source 
Calls to create_volume (both volume_rpcapi and scheduler_rpcapi) pass
mandatory args as optional and reverse. This patch fixes the calls to be
according to the function definition.

Also, fix the call to create_volume in the migration code where
allow_reschedule defaults to True, but we don't pass request_spec so it
prints a warning and disables it.

Change-Id: I9509f88866e0ae182f90ebdfca1fcf415ca60d19
Closes-Bug: #1230069
This commit is contained in:
Avishay Traeger
2013-09-25 08:41:21 +03:00
parent c77868f44b
commit d534811cbc
4 changed files with 11 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
cinder/scheduler/filter_scheduler.py
View File

@@ -80,8 +80,7 @@ class FilterScheduler(driver.Scheduler):
filter_properties.pop('context', None)
self.volume_rpcapi.create_volume(context, updated_volume, host,
request_spec=request_spec,
filter_properties=filter_properties,
request_spec, filter_properties,
allow_reschedule=True,
snapshot_id=snapshot_id,
image_id=image_id)