openstack
/
cinder
Code Issues Proposed changes

SPDK: Report info in top-level volume_stats 

Report basic driver info in the top-level
volume_stats instead of only in volume_stats['pools'].

This aligns SPDK with how most other drivers
report this information.

Related-Bug: #1896764
Change-Id: I1c8b2152c723f512f1013f31661be68b99579c29
This commit is contained in:
Eric Harney 2020-09-23 11:06:30 -04:00
parent 19a128c31b
commit df575898a9
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
cinder/tests/unit/volume/drivers/test_spdk.py
View File

@ -527,6 +527,10 @@ class SpdkDriverTestCase(test.TestCase):
self.assertEqual(1, len(self.driver._stats['pools']))
self.assertEqual("lvs_test",
self.driver._stats['pools'][0]['pool_name'])
self.assertEqual('SPDK', self.driver._stats['volume_backend_name'])
self.assertEqual('Open Source', self.driver._stats['vendor_name'])
self.assertEqual('NVMe-oF', self.driver._stats['storage_protocol'])
self.assertIsNotNone(self.driver._stats['driver_version'])
def test__get_spdk_volume_name(self):
with mock.patch.object(self.driver, "_rpc_call",

5
cinder/volume/drivers/spdk.py
View File

@ -89,7 +89,10 @@ class SPDKDriver(driver.VolumeDriver):
"""Retrieve stats info from volume group."""
LOG.debug('SPDK Updating volume stats')
status = {}
status = {'volume_backend_name': 'SPDK',
'vendor_name': 'Open Source',
'driver_version': self.VERSION,
'storage_protocol': 'NVMe-oF'}
pools_status = []
self.lvs = []