Update NetApp Drivers to use netapp_lib

Like other vendors, NetApp has published a storage controller
client library to PyPI for use by its OpenStack drivers. This
patch updates the NetApp Cinder drivers to use the new library.

The new library, when downloaded from PyPI, provides the REST
and ZAPI interface code that the driver references.
This code was previously part of the driver code tree in
Cinder: netapp/dataontap/client/api.py and netapp/eseries/client.py.
This patchset removes the relevant code from these files
and also modifies the unit tests to work in the absence
of the new library.

Implements: blueprint netapp-use-pypi-client-library

Change-Id: If51c13ade0497c8e89b044bebb393b52da62029a

cinder/tests/unit/volume/drivers/netapp/dataontap/client/test_client_base.py

@@ -20,8 +20,9 @@ import mock
 import six
 
 from cinder import test
+from cinder.tests.unit.volume.drivers.netapp.dataontap.client import (
+    fake_api as netapp_api)
 import cinder.tests.unit.volume.drivers.netapp.dataontap.fakes as fake
-from cinder.volume.drivers.netapp.dataontap.client import api as netapp_api
 from cinder.volume.drivers.netapp.dataontap.client import client_base
 
 
@@ -36,6 +37,11 @@ class NetAppBaseClientTestCase(test.TestCase):
 
     def setUp(self):
         super(NetAppBaseClientTestCase, self).setUp()
+
+        # Inject fake netapp_lib module classes.
+        netapp_api.mock_netapp_lib([client_base])
+
+        self.mock_object(client_base, 'LOG')
         self.client = client_base.Client(**CONNECTION_INFO)
         self.client.connection = mock.MagicMock()
         self.connection = self.client.connection
@@ -128,6 +134,7 @@ class NetAppBaseClientTestCase(test.TestCase):
     def test_create_lun_raises_on_failure(self):
         self.connection.invoke_successfully = mock.Mock(
             side_effect=netapp_api.NaApiError)
+
         self.assertRaises(netapp_api.NaApiError,
                           self.client.create_lun,
                           self.fake_volume,