openstack
/
cinder
Code Issues Proposed changes

Update patch set 2 

Patch Set 2:

(2 comments)

Patch-set: 2
CC: Gerrit User 29122 <29122@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Attention: {"person_ident":"Gerrit User 5314 \u003c5314@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_29122\u003e replied on the change"}
This commit is contained in:
Gerrit User 29122 2024-05-06 06:19:34 +00:00 committed by Gerrit Code Review
parent 175963df5e
commit f5ecd2e90a
1 changed files with 44 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
3bae37f366644ec72031227a4cf564019e192adf Normal file
View File

@ -0,0 +1,44 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "b5783509_61e1f692",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 29122
},
"writtenOn": "2024-05-06T06:19:34Z",
"side": 1,
"message": "Minor query inline",
"revId": "3bae37f366644ec72031227a4cf564019e192adf",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "c4bd590e_718e26e8",
"filename": "cinder/interface/volume_driver.py",
"patchSetId": 2
},
"lineNbr": 38,
"author": {
"id": 29122
},
"writtenOn": "2024-05-06T06:19:34Z",
"side": 1,
"message": "query: should this be ... raise an exception ?",
"range": {
"startLine": 38,
"startChar": 31,
"endLine": 38,
"endChar": 34
},
"revId": "3bae37f366644ec72031227a4cf564019e192adf",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}