openstack/cinder
Code Issues Proposed changes

unit tests: address TODO in base test case

Browse Source 
Change I52ee4b345b0a4b262e330a9a89552cd216eafdbe added a workaround
that has been addressed in oslo.messaging by change
If82c2175cf7242b80509d180cdf92323c0f4c43b so remove the workaround
and increase the min for oslo.messaging in the cinder requirements
to the first release containing the fix.

Change-Id: Ib9e8c28804cc7c67bfdfb438dc3da06f25046b81
This commit is contained in:
Brian Rosmaita
2025-02-13 12:05:35 -05:00
parent d6e99d69ae
commit fcbe82e150
2 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
cinder/tests/unit/test.py
View File

@ -34,7 +34,6 @@ from oslo_config import cfg
from oslo_config import fixture as config_fixture
from oslo_log.fixture import logging_error as log_fixture
import oslo_messaging
from oslo_messaging._drivers import impl_fake as fake_msging
from oslo_messaging import conffixture as messaging_conffixture
from oslo_serialization import jsonutils
from oslo_utils import strutils
@ -201,9 +200,6 @@ class TestCase(testtools.TestCase):
rpc.add_extra_exmods("cinder.tests.unit")
self.addCleanup(rpc.clear_extra_exmods)
self.addCleanup(rpc.cleanup)
# TODO: Remove line after comment once the oslo.messaging fix merges
# https://review.opendev.org/c/openstack/oslo.messaging/+/901018
self.addCleanup(fake_msging.FakeExchangeManager._exchanges.clear)
self.messaging_conf = messaging_conffixture.ConfFixture(CONF)
self.messaging_conf.transport_url = 'fake:/'

2
requirements.txt
View File

@ -16,7 +16,7 @@ oslo.concurrency>=4.5.0 # Apache-2.0
oslo.context>=3.4.0 # Apache-2.0
oslo.db>=11.0.0 # Apache-2.0
oslo.log>=4.6.1 # Apache-2.0
oslo.messaging>=14.1.0 # Apache-2.0
oslo.messaging>=14.6.0 # Apache-2.0
oslo.middleware>=4.1.1 # Apache-2.0
oslo.policy>=4.5.0 # Apache-2.0
oslo.privsep>=2.6.2 # Apache-2.0