cinder/nvmeof-premature-terminate-conn-63e3cc1fd1832874.yaml at 2a1a0bc3e2d8b75aabcb0402239369b14c4e1093 - cinder - OpenDev: Free Software Needs Free Tools

openstack/cinder

Gorka Eguileor daa803b8ee LVM: terminate_connection fails if no initiator

The LVM driver assumes that all connecting hosts will have the iSCSI
initiator installed and configured. If they don't, then there won't be
an "initiator" key in the connector properties dictionary and the call
to terminate connection will always fail with a KeyError exception on
the 'initiator' key.

This is the case if we don't have iSCSI configured on the computes
because we are only using NVMe-oF volumes with the nvmet target.

This patch starts using the dictionary ``get`` method so there is no
failure even when the keys don't exist, and it also differentiates by
target type so they target the identifier they care about, which is the
``initiator`` for iSCSI and ``nqn`` for NVMe-oF.

Closes-Bug: #1966513
Related-Bug: #1786327
Change-Id: Ie967a42188bd020178cb7af527e3dd3ab8975a3d

2023-02-03 14:56:19 +01:00

8 lines

268 B

YAML

Raw Blame History

 ---
 fixes:
   - |
     nvmeof target `bug #1966513
     <https://bugs.launchpad.net/cinder/+bug/1966513>`_: Fixed
     LVM failing on terminate_connection if the connecting host doesn't have an
     iSCSI initiator name setup, for example if LVM is using the nvmet target.