66fcf82521
A subproject has 0 as default values for it's resources. The test methods still expects 'volumes_' + volume_type to be -1 for subproject. This patch adds a check for subproject and updates values accordingly. Change-Id: I03250b7d8c95d3c8dfaebc5538671b1cf08ad9ba
164 lines
6.3 KiB
Python
164 lines
6.3 KiB
Python
# Copyright 2013 Huawei Technologies Co., Ltd
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
"""
|
|
Tests for cinder.api.contrib.quota_classes.py
|
|
"""
|
|
|
|
|
|
import mock
|
|
|
|
from cinder.api.contrib import quota_classes
|
|
from cinder import context
|
|
from cinder import db
|
|
from cinder import exception
|
|
from cinder import quota
|
|
from cinder import test
|
|
from cinder.tests.unit import fake_constants as fake
|
|
from cinder.volume import volume_types
|
|
|
|
|
|
QUOTAS = quota.QUOTAS
|
|
GROUP_QUOTAS = quota.GROUP_QUOTAS
|
|
|
|
|
|
def make_body(root=True, gigabytes=1000, snapshots=10,
|
|
volumes=10, backups=10,
|
|
backup_gigabytes=1000, per_volume_gigabytes=-1,
|
|
volume_types_faked=None,
|
|
tenant_id=fake.PROJECT_ID, groups=10):
|
|
resources = {'gigabytes': gigabytes,
|
|
'snapshots': snapshots,
|
|
'volumes': volumes,
|
|
'backups': backups,
|
|
'per_volume_gigabytes': per_volume_gigabytes,
|
|
'backup_gigabytes': backup_gigabytes,
|
|
'groups': groups}
|
|
if not volume_types_faked:
|
|
volume_types_faked = {'fake_type': None}
|
|
for volume_type in volume_types_faked:
|
|
resources['gigabytes_' + volume_type] = -1
|
|
resources['snapshots_' + volume_type] = -1
|
|
resources['volumes_' + volume_type] = -1
|
|
|
|
# need to consider preexisting volume types as well
|
|
volume_types = db.volume_type_get_all(context.get_admin_context())
|
|
|
|
for volume_type in volume_types:
|
|
resources['gigabytes_' + volume_type] = -1
|
|
resources['snapshots_' + volume_type] = -1
|
|
resources['volumes_' + volume_type] = -1
|
|
|
|
if tenant_id:
|
|
resources['id'] = tenant_id
|
|
if root:
|
|
result = {'quota_class_set': resources}
|
|
else:
|
|
result = resources
|
|
return result
|
|
|
|
|
|
def make_response_body(root=True, ctxt=None, quota_class='foo',
|
|
request_body=None, tenant_id=fake.PROJECT_ID):
|
|
resources = {}
|
|
if not ctxt:
|
|
ctxt = context.get_admin_context()
|
|
resources.update(QUOTAS.get_class_quotas(ctxt, quota_class))
|
|
resources.update(GROUP_QUOTAS.get_class_quotas(ctxt, quota_class))
|
|
if not request_body and not request_body['quota_class_set']:
|
|
resources.update(request_body['quota_class_set'])
|
|
|
|
if tenant_id:
|
|
resources['id'] = tenant_id
|
|
if root:
|
|
result = {'quota_class_set': resources}
|
|
else:
|
|
result = resources
|
|
return result
|
|
|
|
|
|
class QuotaClassSetsControllerTest(test.TestCase):
|
|
|
|
def setUp(self):
|
|
super(QuotaClassSetsControllerTest, self).setUp()
|
|
self.controller = quota_classes.QuotaClassSetsController()
|
|
|
|
self.ctxt = context.get_admin_context()
|
|
self.req = mock.Mock()
|
|
self.req.environ = {'cinder.context': self.ctxt}
|
|
self.req.environ['cinder.context'].is_admin = True
|
|
|
|
def test_show(self):
|
|
volume_types.create(self.ctxt, 'fake_type')
|
|
result = self.controller.show(self.req, fake.PROJECT_ID)
|
|
self.assertDictEqual(make_body(), result)
|
|
|
|
def test_show_not_authorized(self):
|
|
self.req.environ['cinder.context'].is_admin = False
|
|
self.req.environ['cinder.context'].user_id = fake.USER_ID
|
|
self.req.environ['cinder.context'].project_id = fake.PROJECT_ID
|
|
self.assertRaises(exception.PolicyNotAuthorized, self.controller.show,
|
|
self.req, fake.PROJECT_ID)
|
|
|
|
def test_update(self):
|
|
volume_types.create(self.ctxt, 'fake_type')
|
|
body = make_body(gigabytes=2000, snapshots=15,
|
|
volumes=5, tenant_id=None)
|
|
result = self.controller.update(self.req, fake.PROJECT_ID, body=body)
|
|
self.assertDictEqual(body, result)
|
|
|
|
@mock.patch('cinder.api.openstack.wsgi.Controller.validate_string_length')
|
|
def test_update_limit(self, mock_validate):
|
|
volume_types.create(self.ctxt, 'fake_type')
|
|
body = make_body(volumes=5, tenant_id=None)
|
|
result = self.controller.update(self.req, fake.PROJECT_ID, body=body)
|
|
self.assertEqual(5, result['quota_class_set']['volumes'])
|
|
self.assertTrue(mock_validate.called)
|
|
|
|
def test_update_wrong_key(self):
|
|
volume_types.create(self.ctxt, 'fake_type')
|
|
body = {'quota_class_set': {'bad': 100}}
|
|
self.assertRaises(exception.InvalidInput, self.controller.update,
|
|
self.req, fake.PROJECT_ID, body=body)
|
|
|
|
def test_update_invalid_key_value(self):
|
|
body = {'quota_class_set': {'gigabytes': "should_be_int"}}
|
|
self.assertRaises(exception.ValidationError, self.controller.update,
|
|
self.req, fake.PROJECT_ID, body=body)
|
|
|
|
def test_update_bad_quota_limit(self):
|
|
body = {'quota_class_set': {'gigabytes': -1000}}
|
|
self.assertRaises(exception.ValidationError, self.controller.update,
|
|
self.req, fake.PROJECT_ID, body=body)
|
|
|
|
def test_update_no_admin(self):
|
|
self.req.environ['cinder.context'].is_admin = False
|
|
volume_types.create(self.ctxt, 'fake_type')
|
|
self.assertRaises(exception.PolicyNotAuthorized,
|
|
self.controller.update, self.req, fake.PROJECT_ID,
|
|
body=make_body(tenant_id=None))
|
|
|
|
def test_update_with_more_volume_types(self):
|
|
volume_types.create(self.ctxt, 'fake_type_1')
|
|
volume_types.create(self.ctxt, 'fake_type_2')
|
|
body = {'quota_class_set': {'gigabytes_fake_type_1': 1111,
|
|
'volumes_fake_type_2': 2222}}
|
|
result = self.controller.update(self.req, fake.PROJECT_ID, body=body)
|
|
self.assertDictEqual(make_response_body(ctxt=self.ctxt,
|
|
quota_class=fake.PROJECT_ID,
|
|
request_body=body,
|
|
tenant_id=None),
|
|
result)
|