openstack
/
cinder
Code Issues Proposed changes
cinder/cinder/zonemanager/drivers
History
Gorka Eguileor 6dbd08b491 Brocade: Fix AttributeError when raising exception 
When we moved Brocade exceptions from cinder.exception to
cinder.zonemanager.drivers.broade.exception we missed one file,
brcd_rest_fc_zone_client, so when we use that file (setting
`fc_southbound_protocol = REST_HTTP`) if it tries to raise an exception
we end up seeing:

  AttributeError: module 'cinder.exception' has no attribute
  'BrocadeZoningRestException'

The CI didn't catch it because there are no unit tests for the
brcd_rest_fc_zone_client.py file.

This patch fixes the issue by changing the import so it gets the
exceptions from the Brocade file and it also adds some tests for the
first half (211 lines) of the code in the brcd_rest_fc_zone_client.py
file.

TrivialFix
Closes-Bug: #1866860
Change-Id: Idfdb8796d5f4b650aa762e54a189c9ab48f93d1a
 		2020-07-29 10:14:12 +02:00
..
brocade Brocade: Fix AttributeError when raising exception 2020-07-29 10:14:12 +02:00
cisco Introduce flake8-import-order extension 2020-01-06 09:59:35 -06:00
__init__.py Files with no code must be left completely empty 2016-09-28 16:29:30 +07:00
driver_utils.py Remove log translations 2017-03-19 14:59:57 +00:00
fc_zone_driver.py Add unsupported status to driver listing 2016-11-29 18:04:22 +05:30