cinder/fix-unnecessary-migration-on-retype-67cedb1bd8e4c4b2.yaml at 6ff76609c785ef870e6c546bee07da95a6f79d06 - cinder - OpenDev: Free Software Needs Free Tools

openstack/cinder

Gorka Eguileor 7feafe808d Fix unnecessary migration on retype

Retyping a volume with different QoS entries will require a migration,
even if both QoS entries have the exact same data.

This is caused by an incorrect comparison of the QoS information where
we are comparing unnecessary fields: created_at, updated_at, and
deleted_at.

The reason why the unit tests were not picking this up is because the
test was using 'created_at' as one of the spec keys (something artificial
that would not happen in the real world) and it was replacing the value
from the QoS entity.

This patch removes those 3 fields from the QoS comparison, avoiding
unnecessary migrations on retyping.

Close-Bug: #1901188
Change-Id: I979d4db90ee40b4c0a37cd198d7dfcfd7f8d75f7

2020-10-30 17:19:56 +01:00

7 lines

177 B

YAML

Raw Blame History

 ---
 fixes:
   - |
     `Bug #1901188 <https://bugs.launchpad.net/cinder/+bug/1901188>`_: Fix
     unnecessary migration on retype when QoS has the same elements in both
     types.