openstack
/
cinder
Code Issues Proposed changes
cinder/cinder
History
Matt Riedemann 9c0123eb70 Fix _attachment_reserve to not allow attaching an invalid status volume 
It is currently possible to create a volume attachment for a server
when the volume is in error status because of the override logic
in the _attachment_reserve method. What results is that the volume
attach operation fails in nova-compute which rolls back and deletes
the volume attachment, which puts the volume into 'available' status
because it no longer has any attachments, which in fact it should
have never allowed the attachment create/reserve in the first place.

This updates the override logic such that a volume without any
attachments which is in an invalid status will result in an error
being raised.

Change-Id: Id9cf2f510684cd296ffbcaf53d11889cfe8973b9
Closes-Bug: #1785050
 		2018-08-08 16:44:33 -04:00
..
api Merge "Add policy check for type show and type list" 2018-08-07 23:15:51 +00:00
backup Consume quota when importing backup resource 2018-08-01 13:48:25 -05:00
brick Merge "Fixes creation of mirrored volumes due to wrong type" 2017-12-16 02:30:28 +00:00
cmd Get rid of conditional rtslib_fb imports 2018-06-20 16:18:21 -05:00
common Enable split logging for cinder-glanceclient interaction 2018-07-11 14:38:04 +05:30
compute Add user messages for extend volume operation 2018-06-01 09:12:07 +08:00
db Fix some nits in transfer volume with snapshots 2018-07-23 17:36:17 +08:00
group V3 json schema validation: generic volume groups 2018-05-08 18:07:28 +05:30
hacking Fix invalid escape sequence warnings 2018-06-20 16:22:26 -05:00
image Merge "Enable split logging for cinder-glanceclient interaction" 2018-07-15 15:17:34 +00:00
interface Make scheduler check online_extend_support capability 2018-06-26 14:42:34 -03:00
keymgr Handle migrating encryption key IDs in Backup table 2018-04-03 12:23:38 -04:00
locale Imported Translations from Zanata 2018-06-16 06:10:53 +00:00
message Support image signature verification 2018-06-11 10:14:49 +08:00
objects Keep volume's status in 'creating' when creating from backup 2018-06-30 01:40:20 +00:00
policies Merge "Add policy check for type show and type list" 2018-08-07 23:15:51 +00:00
privsep Port nvmet driver to use privsep 2018-07-05 08:11:01 -04:00
scheduler Merge "Make scheduler check online_extend_support capability" 2018-07-13 02:20:26 +00:00
tests Fix _attachment_reserve to not allow attaching an invalid status volume 2018-08-08 16:44:33 -04:00
transfer Transfer snapshots with volumes 2018-07-19 09:42:43 +08:00
volume Fix _attachment_reserve to not allow attaching an invalid status volume 2018-08-08 16:44:33 -04:00
wsgi Initialize osprofiler in WSGI application 2018-01-09 14:06:34 +01:00
zonemanager FC: refactor fczm utils decorators to functions 2018-04-16 16:23:59 -07:00
__init__.py
…
context.py Add Keystone v3 domain information to context 2018-04-25 09:29:33 -04:00
coordination.py Remove deprecated heartbeat options 2017-10-03 14:41:18 -05:00
exception.py Merge "Remove 'message' from format argument from exception" 2018-06-26 05:15:55 +00:00
flow_utils.py
…
i18n.py Replace http with https for doc links in cinder 2017-10-17 11:14:01 +08:00
manager.py Allow configuring tpool size 2018-03-08 15:59:29 +01:00
opts.py Add keystoneauth options to list_opts 2018-07-23 12:02:08 +08:00
policy.py Add cg policies and clean up old policy handling 2017-12-04 10:07:54 +08:00
quota.py V3 jsonschema validation: Quotas 2018-04-27 08:21:51 +05:30
quota_utils.py Add Generic Volume Group Into Quota Management 2017-05-26 01:43:23 +00:00
rpc.py Remove deprecated oslo_messaging.get_transport 2017-06-13 14:25:38 +07:00
service.py Use InvalidConfigurationValue instead of InvalidInput 2018-04-11 19:25:48 +08:00
service_auth.py Add service_token for cinder-nova interaction 2017-12-15 12:04:23 +05:30
ssh_utils.py Stop a connections leak when freeing an SSHPool 2018-02-14 18:16:55 -06:00
test.py Merge "Implement privsep boilerplate in cinder." 2018-06-14 08:04:18 +00:00
utils.py [Logging] Enable filtering of trace_api logs 2018-06-29 10:04:55 -03:00
version.py
…