openstack
/
cinder
Code Issues Proposed changes
cinder/releasenotes
History
Brian Rosmaita 5122b14658 Default volume_type set too early 
If a volume_type is not specified in a volume-create request, change
I4da0c13b5b3f8174a30b8557f968d6b9e641b091 (introduced in Train) sets a
default volume_type in the REST API layer.  This prevents the
selection logic in cinder.volume.flows.api.create_volume.
ExtractVolumeRequestTask from being able to infer the appropriate
volume_type from the source volume, snapshot, or image metadata, and
has caused a regression where the created volume is of the default
type instead of the inferred type.

This patch removes setting the default volume_type in the REST API
and modifies the selection code in ExtractVolumeRequestTask slightly
to make sure a volume_type is always assigned in that function, and
adds and revises some tests.

Change-Id: I05915f2e32b1229ad320cd1c5748de3d63183b91
Closes-bug: #1879578
(cherry picked from commit 674c8e7286)
Conflicts:
  cinder/tests/unit/volume/flows/api/test_create_volume.py
  - cinder.tests.unit.test (victoria) -> cinder.test (pre-victoria)
(cherry picked from commit c1bdb233cf)
Conflicts:
  cinder/volume/flows/api/create_volume.py
  - add six, remove collections
  cinder/tests/unit/volume/flows/api/test_create_volume.py
  - add mock, remove unittest.mock
 		2020-07-12 16:10:27 -04:00
..
notes Default volume_type set too early 2020-07-12 16:10:27 -04:00
source Imported Translations from Zanata 2019-10-04 06:44:38 +00:00
README.rst Fix release notes link 2017-07-25 14:24:18 -07:00

README.rst

Release notes

The release notes for a patch should be included in the patch. The intended audience for release notes include deployers, administrators and end-users.

A release note is required if the patch has upgrade or API impact. It is also required if the patch adds a feature or fixes a long-standing or security bug.

Please see https://docs.openstack.org/cinder/latest/contributor/releasenotes.html for more details.