openstack/cinder
Code Issues Proposed changes
OpenStack Block Storage (Cinder)
8,395 Commits 10 Branches 77 Tags 902 MiB
Python 99.7%
Smarty 0.3%
b4f63203ff
Go to file
Surya Ghatty b4f63203ff Fix sshpool.remove code 
Currently, sshpool.remove function under cinder/ssh_utils.py
is broken. The function tries to locate the passed in
sshclient object inside sshpool.free_items.

However, since the sshclient object is set to “None” at the
beginning, it never finds the object and ends up decrementing
 the current size, without actually removing the object.

Made the following changes to fix:
1. Removed reset to ‘None’ so that the attempt to locate object
goes through.
2. Fixed the code to use free_items.remove(ssh) to remove the ssh
object identified instead of free_items.pop(ssh)
3. Also updated the code to decrement current size only if a match
is found in free_items.
4. Added test case to test remove() of an ssh client that is in the
free_items
5. Added test case to test that remove code does not inadvertently
remove an object from the pool if no match is found.

Change-Id: I4871f4faeb1fc790325f274ab21dc42a8d71fb26
Closes-Bug: #1463557
2016-03-01 03:20:04 +00:00
cinder Fix sshpool.remove code 2016-03-01 03:20:04 +00:00
doc Replace deprecated library function os.popen() with subprocess 2016-01-06 09:36:45 -08:00
etc/cinder Merge "Split out NestedQuotas into a separate driver" 2016-02-19 23:33:51 +00:00
rally-jobs Disable Rally backup-related scenarios 2016-02-15 20:44:52 +02:00
releasenotes Merge "Add SIGHUP handlers to reset RPC version pins" 2016-02-22 13:13:48 +00:00
tools Fix tox -e fast8 2016-01-08 11:05:44 -05:00
.coveragerc Change ignore-errors to ignore_errors 2015-09-21 14:25:22 +00:00
.gitignore Add reno for release notes management 2015-11-05 14:58:17 +01:00
.gitreview Initial fork out of Nova. 2012-05-03 10:48:26 -07:00
.testr.conf Move integrated tests to 'functional' directory 2016-02-09 23:28:27 +02:00
babel.cfg Initial fork out of Nova. 2012-05-03 10:48:26 -07:00
CONTRIBUTING.rst Update CONTRIBUTING.md to CONTRIBUTING.rst 2015-11-10 23:10:38 +08:00
HACKING.rst Hacking Checks for assertTrue/IsNone() 2015-11-25 11:22:35 -06:00
LICENSE Initial fork out of Nova. 2012-05-03 10:48:26 -07:00
MANIFEST.in Use setuptools-git. 2012-08-10 11:56:00 -04:00
openstack-common.conf Move oslo-incubator's scheduler module to cinder 2015-11-24 15:49:31 +01:00
pylintrc Use six to fix imports on Python 3 2015-06-11 17:19:19 +02:00
README.rst Update README.rst to current state 2015-01-12 14:02:24 +01:00
requirements.txt Updated from global requirements 2016-02-20 21:54:23 +00:00
run_tests.sh Detect addition of executable files 2015-08-31 12:19:51 -04:00
setup.cfg Remove version per M-1 release instructions 2015-12-03 08:32:41 -06:00
setup.py Updated from global requirements 2015-09-18 16:37:17 +00:00
test-requirements.txt Updated from global requirements 2016-02-11 07:38:36 +00:00
tests-py3.txt Merge "Port test_emc_vnx to Python 3" 2016-02-23 06:28:33 +00:00
tox.ini Revert changes to use ostestr 2016-02-17 16:04:40 +02:00

README.rst

CINDER

You have come across a storage service for an open cloud computing service. It has identified itself as Cinder. It was abstracted from the Nova project.

Getting Started

If you'd like to run from the master branch, you can clone the git repo:

git clone https://github.com/openstack/cinder.git

For developer information please see HACKING.rst

You can raise bugs here http://bugs.launchpad.net/cinder

Python client

https://github.com/openstack/python-cinderclient.git