7d849b5da4
* Replace StandardError with MemoryError: StandardError was removed in Python 3 * Replace __builtin__ with six.moves.builtins to mock open() * Mock the logger in test_create_iscsi_target() because the test injects errors in open() and the logger uses open() to format the traceback * tox.ini: add cinder.tests.unit.targets.test_iet_driver to Python 3.4 Partial-Implements: blueprint cinder-python3 Change-Id: I7c83da7374ef78cc98bd6c0c5596b7a7adb70303
203 lines
9.1 KiB
Python
203 lines
9.1 KiB
Python
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import contextlib
|
|
|
|
import mock
|
|
from oslo_concurrency import processutils as putils
|
|
import six
|
|
|
|
from cinder import context
|
|
from cinder import exception
|
|
|
|
from cinder.tests.unit.targets import targets_fixture as tf
|
|
from cinder import utils
|
|
from cinder.volume.targets import iet
|
|
|
|
|
|
class TestIetAdmDriver(tf.TargetDriverFixture):
|
|
|
|
def setUp(self):
|
|
super(TestIetAdmDriver, self).setUp()
|
|
self.target = iet.IetAdm(root_helper=utils.get_root_helper(),
|
|
configuration=self.configuration)
|
|
|
|
def test_get_target(self):
|
|
tmp_file = six.StringIO()
|
|
tmp_file.write(
|
|
'tid:1 name:iqn.2010-10.org.openstack:volume-83c2e877-feed-46be-8435-77884fe55b45\n' # noqa
|
|
' sid:844427031282176 initiator:iqn.1994-05.com.redhat:5a6894679665\n' # noqa
|
|
' cid:0 ip:10.9.8.7 state:active hd:none dd:none')
|
|
tmp_file.seek(0)
|
|
with mock.patch('six.moves.builtins.open') as mock_open:
|
|
mock_open.return_value = contextlib.closing(tmp_file)
|
|
self.assertEqual('1',
|
|
self.target._get_target(
|
|
'iqn.2010-10.org.openstack:volume-83c2e877-feed-46be-8435-77884fe55b45' # noqa
|
|
))
|
|
|
|
# Test the failure case: Failed to handle the config file
|
|
mock_open.side_effect = MemoryError()
|
|
self.assertRaises(MemoryError,
|
|
self.target._get_target,
|
|
'')
|
|
|
|
@mock.patch('cinder.volume.targets.iet.IetAdm._get_target',
|
|
return_value=0)
|
|
@mock.patch('cinder.utils.execute')
|
|
@mock.patch('os.path.exists', return_value=True)
|
|
@mock.patch('cinder.utils.temporary_chown')
|
|
@mock.patch.object(iet, 'LOG')
|
|
def test_create_iscsi_target(self, mock_log, mock_chown, mock_exists,
|
|
mock_execute, mock_get_targ):
|
|
mock_execute.return_value = ('', '')
|
|
tmp_file = six.StringIO()
|
|
with mock.patch('six.moves.builtins.open') as mock_open:
|
|
mock_open.return_value = contextlib.closing(tmp_file)
|
|
self.assertEqual(
|
|
0,
|
|
self.target.create_iscsi_target(
|
|
self.test_vol,
|
|
0,
|
|
0,
|
|
self.fake_volumes_dir))
|
|
self.assertTrue(mock_execute.called)
|
|
self.assertTrue(mock_open.called)
|
|
self.assertTrue(mock_get_targ.called)
|
|
|
|
# Test the failure case: Failed to chown the config file
|
|
mock_open.side_effect = putils.ProcessExecutionError
|
|
self.assertRaises(exception.ISCSITargetCreateFailed,
|
|
self.target.create_iscsi_target,
|
|
self.test_vol,
|
|
0,
|
|
0,
|
|
self.fake_volumes_dir)
|
|
|
|
# Test the failure case: Failed to set new auth
|
|
mock_execute.side_effect = putils.ProcessExecutionError
|
|
self.assertRaises(exception.ISCSITargetCreateFailed,
|
|
self.target.create_iscsi_target,
|
|
self.test_vol,
|
|
0,
|
|
0,
|
|
self.fake_volumes_dir)
|
|
|
|
@mock.patch('cinder.utils.execute')
|
|
@mock.patch('os.path.exists', return_value=True)
|
|
def test_update_config_file_failure(self, mock_exists, mock_execute):
|
|
# Test the failure case: conf file does not exist
|
|
mock_exists.return_value = False
|
|
mock_execute.side_effect = putils.ProcessExecutionError
|
|
self.assertRaises(exception.ISCSITargetCreateFailed,
|
|
self.target.update_config_file,
|
|
self.test_vol,
|
|
0,
|
|
self.fake_volumes_dir,
|
|
"foo bar")
|
|
|
|
@mock.patch('cinder.volume.targets.iet.IetAdm._get_target',
|
|
return_value=1)
|
|
@mock.patch('cinder.utils.execute')
|
|
def test_create_iscsi_target_already_exists(self, mock_execute,
|
|
mock_get_targ):
|
|
mock_execute.return_value = ('fake out', 'fake err')
|
|
self.assertEqual(
|
|
1,
|
|
self.target.create_iscsi_target(
|
|
self.test_vol,
|
|
1,
|
|
0,
|
|
self.fake_volumes_dir))
|
|
self.assertTrue(mock_get_targ.called)
|
|
self.assertTrue(mock_execute.called)
|
|
|
|
@mock.patch('cinder.volume.targets.iet.IetAdm._find_sid_cid_for_target',
|
|
return_value=None)
|
|
@mock.patch('os.path.exists', return_value=False)
|
|
@mock.patch('cinder.utils.execute')
|
|
def test_remove_iscsi_target(self, mock_execute, mock_exists, mock_find):
|
|
|
|
# Test the normal case
|
|
self.target.remove_iscsi_target(1,
|
|
0,
|
|
self.testvol['id'],
|
|
self.testvol['name'])
|
|
mock_execute.assert_any_call('ietadm',
|
|
'--op',
|
|
'delete',
|
|
'--tid=1',
|
|
run_as_root=True)
|
|
|
|
# Test the failure case: putils.ProcessExecutionError
|
|
mock_execute.side_effect = putils.ProcessExecutionError
|
|
self.assertRaises(exception.ISCSITargetRemoveFailed,
|
|
self.target.remove_iscsi_target,
|
|
1,
|
|
0,
|
|
self.testvol['id'],
|
|
self.testvol['name'])
|
|
|
|
def test_find_sid_cid_for_target(self):
|
|
tmp_file = six.StringIO()
|
|
tmp_file.write(
|
|
'tid:1 name:iqn.2010-10.org.openstack:volume-83c2e877-feed-46be-8435-77884fe55b45\n' # noqa
|
|
' sid:844427031282176 initiator:iqn.1994-05.com.redhat:5a6894679665\n' # noqa
|
|
' cid:0 ip:10.9.8.7 state:active hd:none dd:none')
|
|
tmp_file.seek(0)
|
|
with mock.patch('six.moves.builtins.open') as mock_open:
|
|
mock_open.return_value = contextlib.closing(tmp_file)
|
|
self.assertEqual(('844427031282176', '0'),
|
|
self.target._find_sid_cid_for_target(
|
|
'1',
|
|
'iqn.2010-10.org.openstack:volume-83c2e877-feed-46be-8435-77884fe55b45', # noqa
|
|
'volume-83c2e877-feed-46be-8435-77884fe55b45' # noqa
|
|
))
|
|
|
|
@mock.patch('cinder.volume.targets.iet.IetAdm._get_target',
|
|
return_value=1)
|
|
@mock.patch('cinder.utils.execute')
|
|
@mock.patch.object(iet.IetAdm, '_get_target_chap_auth')
|
|
def test_create_export(self, mock_get_chap, mock_execute,
|
|
mock_get_targ):
|
|
mock_execute.return_value = ('', '')
|
|
mock_get_chap.return_value = ('QZJbisGmn9AL954FNF4D',
|
|
'P68eE7u9eFqDGexd28DQ')
|
|
expected_result = {'location': '10.9.8.7:3260,1 '
|
|
'iqn.2010-10.org.openstack:testvol 0',
|
|
'auth': 'CHAP '
|
|
'QZJbisGmn9AL954FNF4D P68eE7u9eFqDGexd28DQ'}
|
|
ctxt = context.get_admin_context()
|
|
self.assertEqual(expected_result,
|
|
self.target.create_export(ctxt,
|
|
self.testvol,
|
|
self.fake_volumes_dir))
|
|
self.assertTrue(mock_execute.called)
|
|
|
|
@mock.patch('cinder.volume.targets.iet.IetAdm._get_target_chap_auth',
|
|
return_value=None)
|
|
@mock.patch('cinder.volume.targets.iet.IetAdm._get_target',
|
|
return_value=1)
|
|
def test_ensure_export(self, mock_get_targetm, mock_get_chap):
|
|
ctxt = context.get_admin_context()
|
|
with mock.patch.object(self.target, 'create_iscsi_target'):
|
|
self.target.ensure_export(ctxt,
|
|
self.testvol,
|
|
self.fake_volumes_dir)
|
|
self.target.create_iscsi_target.assert_called_once_with(
|
|
'iqn.2010-10.org.openstack:testvol',
|
|
1, 0, self.fake_volumes_dir, None,
|
|
portals_ips=[self.configuration.iscsi_ip_address],
|
|
portals_port=int(self.configuration.iscsi_port),
|
|
check_exit_code=False,
|
|
old_name=None)
|