707 lines
30 KiB
Python
707 lines
30 KiB
Python
# Copyright (c) 2014 Alex Meade. All rights reserved.
|
|
# Copyright (c) 2014 Clinton Knight. All rights reserved.
|
|
# Copyright (c) 2015 Tom Barron. All rights reserved.
|
|
# Copyright (c) 2016 Mike Rooney. All rights reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
"""
|
|
Mock unit tests for the NetApp block storage C-mode library
|
|
"""
|
|
|
|
import ddt
|
|
import mock
|
|
from oslo_service import loopingcall
|
|
|
|
from cinder import exception
|
|
from cinder import test
|
|
import cinder.tests.unit.volume.drivers.netapp.dataontap.fakes as fake
|
|
import cinder.tests.unit.volume.drivers.netapp.fakes as na_fakes
|
|
from cinder.volume.drivers.netapp.dataontap import block_base
|
|
from cinder.volume.drivers.netapp.dataontap import block_cmode
|
|
from cinder.volume.drivers.netapp.dataontap.client import api as netapp_api
|
|
from cinder.volume.drivers.netapp.dataontap.client import client_base
|
|
from cinder.volume.drivers.netapp.dataontap.performance import perf_cmode
|
|
from cinder.volume.drivers.netapp.dataontap import ssc_cmode
|
|
from cinder.volume.drivers.netapp import utils as na_utils
|
|
|
|
|
|
@ddt.ddt
|
|
class NetAppBlockStorageCmodeLibraryTestCase(test.TestCase):
|
|
"""Test case for NetApp's C-Mode iSCSI library."""
|
|
|
|
def setUp(self):
|
|
super(NetAppBlockStorageCmodeLibraryTestCase, self).setUp()
|
|
|
|
kwargs = {'configuration': self.get_config_cmode()}
|
|
self.library = block_cmode.NetAppBlockStorageCmodeLibrary(
|
|
'driver', 'protocol', **kwargs)
|
|
|
|
self.library.zapi_client = mock.Mock()
|
|
self.zapi_client = self.library.zapi_client
|
|
self.library.perf_library = mock.Mock()
|
|
self.library.vserver = mock.Mock()
|
|
self.library.ssc_vols = None
|
|
self.fake_lun = block_base.NetAppLun(fake.LUN_HANDLE, fake.LUN_NAME,
|
|
fake.SIZE, None)
|
|
self.fake_snapshot_lun = block_base.NetAppLun(
|
|
fake.SNAPSHOT_LUN_HANDLE, fake.SNAPSHOT_NAME, fake.SIZE, None)
|
|
self.mock_object(self.library, 'lun_table')
|
|
self.library.lun_table = {
|
|
fake.LUN_NAME: self.fake_lun,
|
|
fake.SNAPSHOT_NAME: self.fake_snapshot_lun,
|
|
}
|
|
self.mock_object(block_base.NetAppBlockStorageLibrary, 'delete_volume')
|
|
|
|
def tearDown(self):
|
|
super(NetAppBlockStorageCmodeLibraryTestCase, self).tearDown()
|
|
|
|
def get_config_cmode(self):
|
|
config = na_fakes.create_configuration_cmode()
|
|
config.netapp_storage_protocol = 'iscsi'
|
|
config.netapp_login = 'admin'
|
|
config.netapp_password = 'pass'
|
|
config.netapp_server_hostname = '127.0.0.1'
|
|
config.netapp_transport_type = 'https'
|
|
config.netapp_server_port = '443'
|
|
config.netapp_vserver = 'openstack'
|
|
return config
|
|
|
|
@mock.patch.object(perf_cmode, 'PerformanceCmodeLibrary', mock.Mock())
|
|
@mock.patch.object(client_base.Client, 'get_ontapi_version',
|
|
mock.MagicMock(return_value=(1, 20)))
|
|
@mock.patch.object(na_utils, 'check_flags')
|
|
@mock.patch.object(block_base.NetAppBlockStorageLibrary, 'do_setup')
|
|
def test_do_setup(self, super_do_setup, mock_check_flags):
|
|
self.mock_object(client_base.Client, '_init_ssh_client')
|
|
context = mock.Mock()
|
|
|
|
self.library.do_setup(context)
|
|
|
|
super_do_setup.assert_called_once_with(context)
|
|
self.assertEqual(1, mock_check_flags.call_count)
|
|
|
|
def test_check_for_setup_error(self):
|
|
super_check_for_setup_error = self.mock_object(
|
|
block_base.NetAppBlockStorageLibrary, 'check_for_setup_error')
|
|
mock_check_ssc_api_permissions = self.mock_object(
|
|
ssc_cmode, 'check_ssc_api_permissions')
|
|
mock_start_periodic_tasks = self.mock_object(
|
|
self.library, '_start_periodic_tasks')
|
|
self.mock_object(ssc_cmode, 'refresh_cluster_ssc')
|
|
self.mock_object(self.library, '_get_filtered_pools',
|
|
mock.Mock(return_value=fake.FAKE_CMODE_POOLS))
|
|
|
|
self.library.check_for_setup_error()
|
|
|
|
self.assertEqual(1, super_check_for_setup_error.call_count)
|
|
mock_check_ssc_api_permissions.assert_called_once_with(
|
|
self.library.zapi_client)
|
|
self.assertEqual(1, mock_start_periodic_tasks.call_count)
|
|
|
|
def test_check_for_setup_error_no_filtered_pools(self):
|
|
self.mock_object(block_base.NetAppBlockStorageLibrary,
|
|
'check_for_setup_error')
|
|
self.mock_object(ssc_cmode, 'check_ssc_api_permissions')
|
|
self.mock_object(self.library, '_start_periodic_tasks')
|
|
self.mock_object(ssc_cmode, 'refresh_cluster_ssc')
|
|
self.mock_object(self.library, '_get_filtered_pools',
|
|
mock.Mock(return_value=[]))
|
|
|
|
self.assertRaises(exception.NetAppDriverException,
|
|
self.library.check_for_setup_error)
|
|
|
|
def test_find_mapped_lun_igroup(self):
|
|
igroups = [fake.IGROUP1]
|
|
self.zapi_client.get_igroup_by_initiators.return_value = igroups
|
|
|
|
lun_maps = [{'initiator-group': fake.IGROUP1_NAME,
|
|
'lun-id': '1',
|
|
'vserver': fake.VSERVER_NAME}]
|
|
self.zapi_client.get_lun_map.return_value = lun_maps
|
|
|
|
(igroup, lun_id) = self.library._find_mapped_lun_igroup(
|
|
fake.LUN_PATH, fake.FC_FORMATTED_INITIATORS)
|
|
|
|
self.assertEqual(fake.IGROUP1_NAME, igroup)
|
|
self.assertEqual('1', lun_id)
|
|
|
|
def test_find_mapped_lun_igroup_initiator_mismatch(self):
|
|
self.zapi_client.get_igroup_by_initiators.return_value = []
|
|
|
|
lun_maps = [{'initiator-group': fake.IGROUP1_NAME,
|
|
'lun-id': '1',
|
|
'vserver': fake.VSERVER_NAME}]
|
|
self.zapi_client.get_lun_map.return_value = lun_maps
|
|
|
|
(igroup, lun_id) = self.library._find_mapped_lun_igroup(
|
|
fake.LUN_PATH, fake.FC_FORMATTED_INITIATORS)
|
|
|
|
self.assertIsNone(igroup)
|
|
self.assertIsNone(lun_id)
|
|
|
|
def test_find_mapped_lun_igroup_name_mismatch(self):
|
|
igroups = [{'initiator-group-os-type': 'linux',
|
|
'initiator-group-type': 'fcp',
|
|
'initiator-group-name': 'igroup2'}]
|
|
self.zapi_client.get_igroup_by_initiators.return_value = igroups
|
|
|
|
lun_maps = [{'initiator-group': fake.IGROUP1_NAME,
|
|
'lun-id': '1',
|
|
'vserver': fake.VSERVER_NAME}]
|
|
self.zapi_client.get_lun_map.return_value = lun_maps
|
|
|
|
(igroup, lun_id) = self.library._find_mapped_lun_igroup(
|
|
fake.LUN_PATH, fake.FC_FORMATTED_INITIATORS)
|
|
|
|
self.assertIsNone(igroup)
|
|
self.assertIsNone(lun_id)
|
|
|
|
def test_find_mapped_lun_igroup_no_igroup_prefix(self):
|
|
igroups = [{'initiator-group-os-type': 'linux',
|
|
'initiator-group-type': 'fcp',
|
|
'initiator-group-name': 'igroup2'}]
|
|
self.zapi_client.get_igroup_by_initiators.return_value = igroups
|
|
|
|
lun_maps = [{'initiator-group': 'igroup2',
|
|
'lun-id': '1',
|
|
'vserver': fake.VSERVER_NAME}]
|
|
self.zapi_client.get_lun_map.return_value = lun_maps
|
|
|
|
(igroup, lun_id) = self.library._find_mapped_lun_igroup(
|
|
fake.LUN_PATH, fake.FC_FORMATTED_INITIATORS)
|
|
|
|
self.assertIsNone(igroup)
|
|
self.assertIsNone(lun_id)
|
|
|
|
def test_clone_lun_zero_block_count(self):
|
|
"""Test for when clone lun is not passed a block count."""
|
|
|
|
self.library._get_lun_attr = mock.Mock(return_value={'Volume':
|
|
'fakeLUN'})
|
|
self.library.zapi_client = mock.Mock()
|
|
self.library.zapi_client.get_lun_by_args.return_value = [
|
|
mock.Mock(spec=netapp_api.NaElement)]
|
|
lun = fake.FAKE_LUN
|
|
self.library._get_lun_by_args = mock.Mock(return_value=[lun])
|
|
self.library._add_lun_to_table = mock.Mock()
|
|
self.library._update_stale_vols = mock.Mock()
|
|
|
|
self.library._clone_lun('fakeLUN', 'newFakeLUN', 'false')
|
|
|
|
self.library.zapi_client.clone_lun.assert_called_once_with(
|
|
'fakeLUN', 'fakeLUN', 'newFakeLUN', 'false', block_count=0,
|
|
dest_block=0, src_block=0, qos_policy_group_name=None,
|
|
source_snapshot=None)
|
|
|
|
def test_clone_lun_blocks(self):
|
|
"""Test for when clone lun is passed block information."""
|
|
block_count = 10
|
|
src_block = 10
|
|
dest_block = 30
|
|
|
|
self.library._get_lun_attr = mock.Mock(return_value={'Volume':
|
|
'fakeLUN'})
|
|
self.library.zapi_client = mock.Mock()
|
|
self.library.zapi_client.get_lun_by_args.return_value = [
|
|
mock.Mock(spec=netapp_api.NaElement)]
|
|
lun = fake.FAKE_LUN
|
|
self.library._get_lun_by_args = mock.Mock(return_value=[lun])
|
|
self.library._add_lun_to_table = mock.Mock()
|
|
self.library._update_stale_vols = mock.Mock()
|
|
|
|
self.library._clone_lun('fakeLUN', 'newFakeLUN', 'false',
|
|
block_count=block_count, src_block=src_block,
|
|
dest_block=dest_block)
|
|
|
|
self.library.zapi_client.clone_lun.assert_called_once_with(
|
|
'fakeLUN', 'fakeLUN', 'newFakeLUN', 'false',
|
|
block_count=block_count, dest_block=dest_block,
|
|
src_block=src_block, qos_policy_group_name=None,
|
|
source_snapshot=None)
|
|
|
|
def test_clone_lun_no_space_reservation(self):
|
|
"""Test for when space_reservation is not passed."""
|
|
|
|
self.library._get_lun_attr = mock.Mock(return_value={'Volume':
|
|
'fakeLUN'})
|
|
self.library.zapi_client = mock.Mock()
|
|
self.library.lun_space_reservation = 'false'
|
|
self.library.zapi_client.get_lun_by_args.return_value = [
|
|
mock.Mock(spec=netapp_api.NaElement)]
|
|
lun = fake.FAKE_LUN
|
|
self.library._get_lun_by_args = mock.Mock(return_value=[lun])
|
|
self.library._add_lun_to_table = mock.Mock()
|
|
self.library._update_stale_vols = mock.Mock()
|
|
|
|
self.library._clone_lun('fakeLUN', 'newFakeLUN')
|
|
|
|
self.library.zapi_client.clone_lun.assert_called_once_with(
|
|
'fakeLUN', 'fakeLUN', 'newFakeLUN', 'false', block_count=0,
|
|
dest_block=0, src_block=0, qos_policy_group_name=None,
|
|
source_snapshot=None)
|
|
|
|
def test_get_fc_target_wwpns(self):
|
|
ports = [fake.FC_FORMATTED_TARGET_WWPNS[0],
|
|
fake.FC_FORMATTED_TARGET_WWPNS[1]]
|
|
self.zapi_client.get_fc_target_wwpns.return_value = ports
|
|
|
|
result = self.library._get_fc_target_wwpns()
|
|
|
|
self.assertSetEqual(set(ports), set(result))
|
|
|
|
@mock.patch.object(ssc_cmode, 'refresh_cluster_ssc', mock.Mock())
|
|
@mock.patch.object(block_cmode.NetAppBlockStorageCmodeLibrary,
|
|
'_get_pool_stats', mock.Mock())
|
|
def test_vol_stats_calls_provide_ems(self):
|
|
self.library.zapi_client.provide_ems = mock.Mock()
|
|
|
|
self.library.get_volume_stats(refresh=True)
|
|
|
|
self.assertEqual(1, self.library.zapi_client.provide_ems.call_count)
|
|
|
|
def test_create_lun(self):
|
|
self.library._update_stale_vols = mock.Mock()
|
|
|
|
self.library._create_lun(fake.VOLUME_ID, fake.LUN_ID,
|
|
fake.LUN_SIZE, fake.LUN_METADATA)
|
|
|
|
self.library.zapi_client.create_lun.assert_called_once_with(
|
|
fake.VOLUME_ID, fake.LUN_ID, fake.LUN_SIZE, fake.LUN_METADATA,
|
|
None)
|
|
self.assertEqual(1, self.library._update_stale_vols.call_count)
|
|
|
|
@mock.patch.object(ssc_cmode, 'get_volumes_for_specs')
|
|
@mock.patch.object(ssc_cmode, 'get_cluster_latest_ssc')
|
|
def test_check_volume_type_for_lun_fail(self, get_ssc, get_vols):
|
|
self.library.ssc_vols = ['vol']
|
|
fake_extra_specs = {'specs': 's'}
|
|
get_vols.return_value = [ssc_cmode.NetAppVolume(name='name',
|
|
vserver='vs')]
|
|
mock_lun = block_base.NetAppLun('handle', 'name', '1',
|
|
{'Volume': 'fake', 'Path': '/vol/lun'})
|
|
self.assertRaises(exception.ManageExistingVolumeTypeMismatch,
|
|
self.library._check_volume_type_for_lun,
|
|
{'vol': 'vol'}, mock_lun, {'ref': 'ref'},
|
|
fake_extra_specs)
|
|
get_vols.assert_called_with(['vol'], {'specs': 's'})
|
|
self.assertEqual(1, get_ssc.call_count)
|
|
|
|
def test_get_preferred_target_from_list(self):
|
|
target_details_list = fake.ISCSI_TARGET_DETAILS_LIST
|
|
operational_addresses = [
|
|
target['address']
|
|
for target in target_details_list[2:]]
|
|
self.zapi_client.get_operational_network_interface_addresses = (
|
|
mock.Mock(return_value=operational_addresses))
|
|
|
|
result = self.library._get_preferred_target_from_list(
|
|
target_details_list)
|
|
|
|
self.assertEqual(target_details_list[2], result)
|
|
|
|
def test_get_pool_stats_no_volumes(self):
|
|
|
|
self.library.ssc_vols = []
|
|
|
|
result = self.library._get_pool_stats()
|
|
|
|
self.assertListEqual([], result)
|
|
|
|
@ddt.data({'thin': True, 'netapp_lun_space_reservation': 'enabled'},
|
|
{'thin': True, 'netapp_lun_space_reservation': 'disabled'},
|
|
{'thin': False, 'netapp_lun_space_reservation': 'enabled'},
|
|
{'thin': False, 'netapp_lun_space_reservation': 'disabled'})
|
|
@ddt.unpack
|
|
def test_get_pool_stats(self, thin, netapp_lun_space_reservation):
|
|
|
|
class test_volume(object):
|
|
self.id = None
|
|
self.aggr = None
|
|
|
|
test_volume = test_volume()
|
|
test_volume.id = {'vserver': 'openstack', 'name': 'vola'}
|
|
test_volume.aggr = {
|
|
'disk_type': 'SSD',
|
|
'ha_policy': 'cfo',
|
|
'junction': '/vola',
|
|
'name': 'aggr1',
|
|
'raid_type': 'raiddp'
|
|
}
|
|
test_volume.space = {
|
|
'space-guarantee': 'file',
|
|
'space-guarantee-enabled': False,
|
|
'thin_provisioned': False
|
|
}
|
|
test_volume.sis = {'dedup': False, 'compression': False}
|
|
test_volume.state = {
|
|
'status': 'online',
|
|
'vserver_root': False,
|
|
'junction_active': True
|
|
}
|
|
test_volume.qos = {'qos_policy_group': None}
|
|
|
|
ssc_map = {
|
|
'mirrored': {},
|
|
'dedup': {},
|
|
'compression': {},
|
|
'thin': {test_volume if thin else None},
|
|
'all': [test_volume]
|
|
}
|
|
self.library.ssc_vols = ssc_map
|
|
self.library.reserved_percentage = 5
|
|
self.library.max_over_subscription_ratio = 10
|
|
self.library.configuration.netapp_lun_space_reservation = (
|
|
netapp_lun_space_reservation)
|
|
self.library.perf_library.get_node_utilization_for_pool = (
|
|
mock.Mock(return_value=30.0))
|
|
mock_capacities = {
|
|
'size-total': 10737418240.0,
|
|
'size-available': 2147483648.0,
|
|
}
|
|
self.mock_object(
|
|
self.zapi_client, 'get_flexvol_capacity',
|
|
mock.Mock(return_value=mock_capacities))
|
|
|
|
netapp_thin = 'true' if thin else 'false'
|
|
netapp_thick = 'false' if thin else 'true'
|
|
|
|
thick = not thin and (netapp_lun_space_reservation == 'enabled')
|
|
|
|
result = self.library._get_pool_stats(filter_function='filter',
|
|
goodness_function='goodness')
|
|
|
|
expected = [{'pool_name': 'vola',
|
|
'consistencygroup_support': True,
|
|
'netapp_unmirrored': 'true',
|
|
'QoS_support': True,
|
|
'thin_provisioning_support': not thick,
|
|
'thick_provisioning_support': thick,
|
|
'provisioned_capacity_gb': 8.0,
|
|
'netapp_thick_provisioned': netapp_thick,
|
|
'netapp_nocompression': 'true',
|
|
'free_capacity_gb': 2.0,
|
|
'netapp_thin_provisioned': netapp_thin,
|
|
'total_capacity_gb': 10.0,
|
|
'netapp_compression': 'false',
|
|
'netapp_mirrored': 'false',
|
|
'netapp_dedup': 'false',
|
|
'reserved_percentage': 5,
|
|
'max_over_subscription_ratio': 10.0,
|
|
'netapp_raid_type': 'raiddp',
|
|
'netapp_disk_type': 'SSD',
|
|
'netapp_nodedup': 'true',
|
|
'utilization': 30.0,
|
|
'filter_function': 'filter',
|
|
'goodness_function': 'goodness'}]
|
|
|
|
self.assertEqual(expected, result)
|
|
|
|
def test_delete_volume(self):
|
|
self.mock_object(block_base.NetAppLun, 'get_metadata_property',
|
|
mock.Mock(return_value=fake.POOL_NAME))
|
|
self.mock_object(self.library, '_update_stale_vols')
|
|
self.mock_object(na_utils, 'get_valid_qos_policy_group_info',
|
|
mock.Mock(
|
|
return_value=fake.QOS_POLICY_GROUP_INFO))
|
|
self.mock_object(self.library, '_mark_qos_policy_group_for_deletion')
|
|
|
|
self.library.delete_volume(fake.VOLUME)
|
|
|
|
self.assertEqual(1,
|
|
block_base.NetAppLun.get_metadata_property.call_count)
|
|
block_base.NetAppBlockStorageLibrary.delete_volume\
|
|
.assert_called_once_with(fake.VOLUME)
|
|
na_utils.get_valid_qos_policy_group_info.assert_called_once_with(
|
|
fake.VOLUME)
|
|
self.library._mark_qos_policy_group_for_deletion\
|
|
.assert_called_once_with(fake.QOS_POLICY_GROUP_INFO)
|
|
self.assertEqual(1, self.library._update_stale_vols.call_count)
|
|
|
|
def test_delete_volume_no_netapp_vol(self):
|
|
self.mock_object(block_base.NetAppLun, 'get_metadata_property',
|
|
mock.Mock(return_value=None))
|
|
self.mock_object(self.library, '_update_stale_vols')
|
|
self.mock_object(na_utils, 'get_valid_qos_policy_group_info',
|
|
mock.Mock(
|
|
return_value=fake.QOS_POLICY_GROUP_INFO))
|
|
self.mock_object(self.library, '_mark_qos_policy_group_for_deletion')
|
|
|
|
self.library.delete_volume(fake.VOLUME)
|
|
|
|
block_base.NetAppLun.get_metadata_property.assert_called_once_with(
|
|
'Volume')
|
|
block_base.NetAppBlockStorageLibrary.delete_volume\
|
|
.assert_called_once_with(fake.VOLUME)
|
|
self.library._mark_qos_policy_group_for_deletion\
|
|
.assert_called_once_with(fake.QOS_POLICY_GROUP_INFO)
|
|
self.assertEqual(0, self.library._update_stale_vols.call_count)
|
|
|
|
def test_delete_volume_get_valid_qos_policy_group_info_exception(self):
|
|
self.mock_object(block_base.NetAppLun, 'get_metadata_property',
|
|
mock.Mock(return_value=fake.NETAPP_VOLUME))
|
|
self.mock_object(self.library, '_update_stale_vols')
|
|
self.mock_object(na_utils, 'get_valid_qos_policy_group_info',
|
|
mock.Mock(side_effect=exception.Invalid))
|
|
self.mock_object(self.library, '_mark_qos_policy_group_for_deletion')
|
|
|
|
self.library.delete_volume(fake.VOLUME)
|
|
|
|
block_base.NetAppLun.get_metadata_property.assert_called_once_with(
|
|
'Volume')
|
|
block_base.NetAppBlockStorageLibrary.delete_volume\
|
|
.assert_called_once_with(fake.VOLUME)
|
|
self.library._mark_qos_policy_group_for_deletion\
|
|
.assert_called_once_with(None)
|
|
self.assertEqual(1, self.library._update_stale_vols.call_count)
|
|
|
|
def test_delete_snapshot(self):
|
|
self.mock_object(block_base.NetAppLun, 'get_metadata_property',
|
|
mock.Mock(return_value=fake.NETAPP_VOLUME))
|
|
mock_super_delete_snapshot = self.mock_object(
|
|
block_base.NetAppBlockStorageLibrary, 'delete_snapshot')
|
|
mock_update_stale_vols = self.mock_object(self.library,
|
|
'_update_stale_vols')
|
|
self.library.delete_snapshot(fake.SNAPSHOT)
|
|
|
|
mock_super_delete_snapshot.assert_called_once_with(fake.SNAPSHOT)
|
|
self.assertTrue(mock_update_stale_vols.called)
|
|
|
|
def test_delete_snapshot_no_netapp_vol(self):
|
|
self.mock_object(block_base.NetAppLun, 'get_metadata_property',
|
|
mock.Mock(return_value=None))
|
|
mock_super_delete_snapshot = self.mock_object(
|
|
block_base.NetAppBlockStorageLibrary, 'delete_snapshot')
|
|
mock_update_stale_vols = self.mock_object(self.library,
|
|
'_update_stale_vols')
|
|
self.library.delete_snapshot(fake.SNAPSHOT)
|
|
|
|
mock_super_delete_snapshot.assert_called_once_with(fake.SNAPSHOT)
|
|
self.assertFalse(mock_update_stale_vols.called)
|
|
|
|
def test_setup_qos_for_volume(self):
|
|
self.mock_object(na_utils, 'get_valid_qos_policy_group_info',
|
|
mock.Mock(
|
|
return_value=fake.QOS_POLICY_GROUP_INFO))
|
|
self.mock_object(self.zapi_client, 'provision_qos_policy_group')
|
|
|
|
result = self.library._setup_qos_for_volume(fake.VOLUME,
|
|
fake.EXTRA_SPECS)
|
|
|
|
self.assertEqual(fake.QOS_POLICY_GROUP_INFO, result)
|
|
self.zapi_client.provision_qos_policy_group.\
|
|
assert_called_once_with(fake.QOS_POLICY_GROUP_INFO)
|
|
|
|
def test_setup_qos_for_volume_exception_path(self):
|
|
self.mock_object(na_utils, 'get_valid_qos_policy_group_info',
|
|
mock.Mock(
|
|
side_effect=exception.Invalid))
|
|
self.mock_object(self.zapi_client, 'provision_qos_policy_group')
|
|
|
|
self.assertRaises(exception.VolumeBackendAPIException,
|
|
self.library._setup_qos_for_volume, fake.VOLUME,
|
|
fake.EXTRA_SPECS)
|
|
|
|
self.assertEqual(0,
|
|
self.zapi_client.
|
|
provision_qos_policy_group.call_count)
|
|
|
|
def test_mark_qos_policy_group_for_deletion(self):
|
|
self.mock_object(self.zapi_client,
|
|
'mark_qos_policy_group_for_deletion')
|
|
|
|
self.library._mark_qos_policy_group_for_deletion(
|
|
fake.QOS_POLICY_GROUP_INFO)
|
|
|
|
self.zapi_client.mark_qos_policy_group_for_deletion\
|
|
.assert_called_once_with(fake.QOS_POLICY_GROUP_INFO)
|
|
|
|
def test_unmanage(self):
|
|
self.mock_object(na_utils, 'get_valid_qos_policy_group_info',
|
|
mock.Mock(return_value=fake.QOS_POLICY_GROUP_INFO))
|
|
self.mock_object(self.library, '_mark_qos_policy_group_for_deletion')
|
|
self.mock_object(block_base.NetAppBlockStorageLibrary, 'unmanage')
|
|
|
|
self.library.unmanage(fake.VOLUME)
|
|
|
|
na_utils.get_valid_qos_policy_group_info.assert_called_once_with(
|
|
fake.VOLUME)
|
|
self.library._mark_qos_policy_group_for_deletion\
|
|
.assert_called_once_with(fake.QOS_POLICY_GROUP_INFO)
|
|
block_base.NetAppBlockStorageLibrary.unmanage.assert_called_once_with(
|
|
fake.VOLUME)
|
|
|
|
def test_unmanage_w_invalid_qos_policy(self):
|
|
self.mock_object(na_utils, 'get_valid_qos_policy_group_info',
|
|
mock.Mock(side_effect=exception.Invalid))
|
|
self.mock_object(self.library, '_mark_qos_policy_group_for_deletion')
|
|
self.mock_object(block_base.NetAppBlockStorageLibrary, 'unmanage')
|
|
|
|
self.library.unmanage(fake.VOLUME)
|
|
|
|
na_utils.get_valid_qos_policy_group_info.assert_called_once_with(
|
|
fake.VOLUME)
|
|
self.library._mark_qos_policy_group_for_deletion\
|
|
.assert_called_once_with(None)
|
|
block_base.NetAppBlockStorageLibrary.unmanage.assert_called_once_with(
|
|
fake.VOLUME)
|
|
|
|
def test_manage_existing_lun_same_name(self):
|
|
mock_lun = block_base.NetAppLun('handle', 'name', '1',
|
|
{'Path': '/vol/FAKE_CMODE_VOL1/name'})
|
|
self.library._get_existing_vol_with_manage_ref = mock.Mock(
|
|
return_value=mock_lun)
|
|
self.mock_object(na_utils, 'get_volume_extra_specs')
|
|
self.mock_object(na_utils, 'log_extra_spec_warnings')
|
|
self.library._check_volume_type_for_lun = mock.Mock()
|
|
self.library._setup_qos_for_volume = mock.Mock()
|
|
self.mock_object(na_utils, 'get_qos_policy_group_name_from_info',
|
|
mock.Mock(return_value=fake.QOS_POLICY_GROUP_NAME))
|
|
self.library._add_lun_to_table = mock.Mock()
|
|
self.zapi_client.move_lun = mock.Mock()
|
|
mock_set_lun_qos_policy_group = self.mock_object(
|
|
self.zapi_client, 'set_lun_qos_policy_group')
|
|
|
|
self.library.manage_existing({'name': 'name'}, {'ref': 'ref'})
|
|
|
|
self.library._get_existing_vol_with_manage_ref.assert_called_once_with(
|
|
{'ref': 'ref'})
|
|
self.assertEqual(1, self.library._check_volume_type_for_lun.call_count)
|
|
self.assertEqual(1, self.library._add_lun_to_table.call_count)
|
|
self.assertEqual(0, self.zapi_client.move_lun.call_count)
|
|
self.assertEqual(1, mock_set_lun_qos_policy_group.call_count)
|
|
|
|
def test_manage_existing_lun_new_path(self):
|
|
mock_lun = block_base.NetAppLun(
|
|
'handle', 'name', '1', {'Path': '/vol/FAKE_CMODE_VOL1/name'})
|
|
self.library._get_existing_vol_with_manage_ref = mock.Mock(
|
|
return_value=mock_lun)
|
|
self.mock_object(na_utils, 'get_volume_extra_specs')
|
|
self.mock_object(na_utils, 'log_extra_spec_warnings')
|
|
self.library._check_volume_type_for_lun = mock.Mock()
|
|
self.library._add_lun_to_table = mock.Mock()
|
|
self.zapi_client.move_lun = mock.Mock()
|
|
|
|
self.library.manage_existing({'name': 'volume'}, {'ref': 'ref'})
|
|
|
|
self.assertEqual(
|
|
2, self.library._get_existing_vol_with_manage_ref.call_count)
|
|
self.assertEqual(1, self.library._check_volume_type_for_lun.call_count)
|
|
self.assertEqual(1, self.library._add_lun_to_table.call_count)
|
|
self.zapi_client.move_lun.assert_called_once_with(
|
|
'/vol/FAKE_CMODE_VOL1/name', '/vol/FAKE_CMODE_VOL1/volume')
|
|
|
|
def test_start_periodic_tasks(self):
|
|
|
|
mock_remove_unused_qos_policy_groups = self.mock_object(
|
|
self.zapi_client,
|
|
'remove_unused_qos_policy_groups')
|
|
|
|
harvest_qos_periodic_task = mock.Mock()
|
|
mock_loopingcall = self.mock_object(
|
|
loopingcall,
|
|
'FixedIntervalLoopingCall',
|
|
mock.Mock(side_effect=[harvest_qos_periodic_task]))
|
|
|
|
self.library._start_periodic_tasks()
|
|
|
|
mock_loopingcall.assert_has_calls([
|
|
mock.call(mock_remove_unused_qos_policy_groups)])
|
|
self.assertTrue(harvest_qos_periodic_task.start.called)
|
|
|
|
@ddt.data('open+|demix+', 'open.+', '.+\d', '^((?!mix+).)*$',
|
|
'open123, open321')
|
|
def test_get_filtered_pools_match_selected_pools(self, patterns):
|
|
|
|
self.library.ssc_vols = fake.FAKE_CMODE_VOLUME
|
|
self.library.configuration.netapp_pool_name_search_pattern = patterns
|
|
|
|
filtered_pools = self.library._get_filtered_pools()
|
|
|
|
self.assertEqual(fake.FAKE_CMODE_VOLUME['all'][0].id['name'],
|
|
filtered_pools[0].id['name'])
|
|
self.assertEqual(fake.FAKE_CMODE_VOLUME['all'][2].id['name'],
|
|
filtered_pools[1].id['name'])
|
|
|
|
@ddt.data('', 'mix.+|open.+', '.+', 'open123, mixed, open321',
|
|
'.*?')
|
|
def test_get_filtered_pools_match_all_pools(self, patterns):
|
|
|
|
self.library.ssc_vols = fake.FAKE_CMODE_VOLUME
|
|
self.library.configuration.netapp_pool_name_search_pattern = patterns
|
|
|
|
filtered_pools = self.library._get_filtered_pools()
|
|
|
|
self.assertEqual(fake.FAKE_CMODE_VOLUME['all'][0].id['name'],
|
|
filtered_pools[0].id['name'])
|
|
self.assertEqual(fake.FAKE_CMODE_VOLUME['all'][1].id['name'],
|
|
filtered_pools[1].id['name'])
|
|
self.assertEqual(fake.FAKE_CMODE_VOLUME['all'][2].id['name'],
|
|
filtered_pools[2].id['name'])
|
|
|
|
def test_get_filtered_pools_invalid_conf(self):
|
|
"""Verify an exception is raised if the regex pattern is invalid"""
|
|
self.library.configuration.netapp_pool_name_search_pattern = '(.+'
|
|
|
|
self.assertRaises(exception.InvalidConfigurationValue,
|
|
self.library._get_filtered_pools)
|
|
|
|
@ddt.data('abc|stackopen|openstack|abc*', 'abc', 'stackopen', 'openstack',
|
|
'abc*', '^$')
|
|
def test_get_filtered_pools_non_matching_patterns(self, patterns):
|
|
|
|
self.library.ssc_vols = fake.FAKE_CMODE_VOLUME
|
|
self.library.configuration.netapp_pool_name_search_pattern = patterns
|
|
|
|
filtered_pools = self.library._get_filtered_pools()
|
|
|
|
self.assertListEqual([], filtered_pools)
|
|
|
|
@ddt.data({}, None)
|
|
def test_get_pool_stats_no_ssc_vols(self, vols):
|
|
|
|
self.library.ssc_vols = vols
|
|
|
|
pools = self.library._get_pool_stats()
|
|
|
|
self.assertListEqual([], pools)
|
|
|
|
def test_get_pool_stats_with_filtered_pools(self):
|
|
|
|
self.library.ssc_vols = fake.ssc_map
|
|
self.mock_object(self.library, '_get_filtered_pools',
|
|
mock.Mock(return_value=[fake.FAKE_CMODE_VOL1]))
|
|
self.library.perf_library.get_node_utilization_for_pool = (
|
|
mock.Mock(return_value=30.0))
|
|
mock_capacities = {
|
|
'size-total': 5000000000.0,
|
|
'size-available': 4000000000.0,
|
|
}
|
|
self.mock_object(
|
|
self.zapi_client, 'get_flexvol_capacity',
|
|
mock.Mock(return_value=mock_capacities))
|
|
|
|
pools = self.library._get_pool_stats(filter_function='filter',
|
|
goodness_function='goodness')
|
|
|
|
self.assertListEqual(fake.FAKE_CMODE_POOLS, pools)
|
|
|
|
def test_get_pool_stats_no_filtered_pools(self):
|
|
|
|
self.library.ssc_vols = fake.ssc_map
|
|
self.mock_object(self.library, '_get_filtered_pools',
|
|
mock.Mock(return_value=[]))
|
|
|
|
pools = self.library._get_pool_stats()
|
|
|
|
self.assertListEqual([], pools)
|