e96dcc4e97
As seen in output of showport command below, there is possibility of same ip address (172.28.50.151) being used for trunk iSCSI ip and vlan ip. s0452 cli% showport -iscsi N:S:P State IPAddr Netmask/PrefixLen Gateway TPGT . . . 0:4:2 ready 172.28.50.151 255.255.0.0 0.0.0.0 42 . . . --------------------------------------------------------- 1 s0452 cli% s0452 cli% showport -iscsivlans N:S:P VLAN IPAddr Netmask/PrefixLen Gateway . . . 0:4:2 untagged 172.28.50.151 255.255.0.0 0.0.0.0 . . . - 5 172.28.50.240 255.255.0.0 0.0.0.0 . . . ------------------------------------------------------ 2 s0452 cli% This patch checks for duplicate IP and ignores them; thus avoiding multiple calls (to create lun) for same IP. Why this change is needed: Below is the use case. 1. initialize connection function is invoked. 2. using trunk iSCSI ip 172.28.50.151, create lun invoked. 3. With vlan ip 172.28.50.151, it again tries to create lun. 4. And this fails because LUN is already created (with same ip) in step 2. Extract from cinder-volume log: Driver initialize connection failed (error: Conflict (HTTP 409) 18 - LUN exists). Solution: While processing vlan ip, check if its same as iSCSI ip. If so, skip the lun creation. Closes-Bug: #2112433 Depends-On: I91cd5e262513b5427377ce1892e9acfe29e22b21 Change-Id: I582c27d8d8a8e22d03b2d68152cb467a6db606bc Signed-off-by: raghavendrat <raghavendra-uddhav.tilay@hpe.com> (cherry picked from commit255ccd6c6c) (cherry picked from commitdf190f7f4c)
Release notes
The release notes for a patch should be included in the patch. The intended audience for release notes include deployers, administrators and end-users.
A release note is required if the patch has upgrade or API impact. It is also required if the patch adds a feature or fixes a long-standing or security bug.
Please see https://docs.openstack.org/cinder/latest/contributor/releasenotes.html for more details.