openstack
/
cinder
Code Issues Proposed changes
cinder/cinder/tests
History
Rodrigo Barbieri f3cdc27563 Fix cross-project incremental backups 
This patch addresses the scenario where an
incremental backup can be created having a
parent backup that was taken in a different
project. This scenario ultimately leads to
a silent error when creating/deleting the
incremental backup and quotas going out of
sync.

The proposed fix is to narrow the backup search
down to the same project. To achieve this, a
method's signature had to be updated to achieve
the desired optimized behavior of passing the
volume's project_id parameter.

Closes-bug: #1869746
Closes-bug: #1873518

conflicts:
    cinder/tests/unit/backup/test_backup.py

Test test_create_backup_failed_with_empty_backup_objects
required a mock for
test_create_backup_failed_with_empty_backup_objects
which had been removed in ussuri, as part of commit
f0211b53b8. That
commit removed code and leftover the mock, which I
had removed in the change this patch was
cherry-picked from, as it was unnecessary.

The removed code section of cinder/backup/api.py
from commit f0211b53b8
does not impact the functionality of this change at all.

Change-Id: Icb621ff5966133f59d9d43ca2dd9f8e1919b1149
(cherry picked from commit 8ebeafcbba)
(cherry picked from commit 5358c996b4)
 		2020-07-02 19:39:00 -03:00
..
compliance
…
functional Untyped to Default Volume Type 2019-09-20 05:37:54 +00:00
hacking Move hacking checks to tests dir 2019-10-09 14:16:58 -04:00
unit Fix cross-project incremental backups 2020-07-02 19:39:00 -03:00
README.rst Update the documentation link 2017-08-26 06:52:48 -07:00
__init__.py
…
fake_driver.py Rename volume/utils.py to volume/volume_utils.py 2019-09-09 15:00:07 -04:00
fixtures.py Implement privsep boilerplate in cinder. 2018-06-06 09:42:54 +08:00

README.rst

IMPORTANT DEFINITION OF TESTS IN CINDER

Cinder has a number of different test types, PLEASE be sure to refer to the Cinder Testing Docs to familiarize yourself with the various options before creating any new tests.

Please check Cinder-Testing.